Skip to content

Kill Boogie and Z3 processes when Carbon is interrupted#426

Merged
gauravpartha merged 6 commits into
masterfrom
kill-z3
Jan 18, 2023
Merged

Kill Boogie and Z3 processes when Carbon is interrupted#426
gauravpartha merged 6 commits into
masterfrom
kill-z3

Conversation

@dewert99

@dewert99 dewert99 commented Jul 4, 2022

Copy link
Copy Markdown
Contributor

Makes sure Carbon kills its Boogie and Z3 subprocesses when interrupted.

@gauravpartha

Copy link
Copy Markdown
Contributor

Rebased branch onto master

@fpoli

fpoli commented Jan 11, 2023

Copy link
Copy Markdown
Member

In case it's useful, Silicon additionally uses a shutdown hook: [1] [2]

@gauravpartha

gauravpartha commented Jan 18, 2023

Copy link
Copy Markdown
Contributor

In case it's useful, Silicon additionally uses a shutdown hook: [1] [2]

Thanks for the pointer! I have now added an analogous hook to Carbon in this PR.

@gauravpartha gauravpartha self-assigned this Jan 18, 2023

@marcoeilers marcoeilers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauravpartha gauravpartha changed the title Kill z3 Kill Boogie and Z3 process when Carbon is interrupted Jan 18, 2023
@gauravpartha gauravpartha changed the title Kill Boogie and Z3 process when Carbon is interrupted Kill Boogie and Z3 processes when Carbon is interrupted Jan 18, 2023
@gauravpartha gauravpartha merged commit 104267e into master Jan 18, 2023
@gauravpartha gauravpartha deleted the kill-z3 branch January 18, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants