Skip to content

Kill Boogie and Z3 processes when Carbon is interrupted #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gauravpartha merged 6 commits into from
Jan 18, 2023
Merged

Kill Boogie and Z3 processes when Carbon is interrupted #426

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b851a84
Made sure processes were destroyed if they timed out
dewert99 Jun 20, 2022
1d30b46
Also kill Boogies children (Z3) on timeout
dewert99 Jun 23, 2022
79fc084
user shutdown hook
gauravpartha Jan 18, 2023
3163d89
minor
gauravpartha Jan 18, 2023
b1ec2f7
minor
gauravpartha Jan 18, 2023
b1f4c42
minor
gauravpartha Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 31 additions & 13 deletions src/main/scala/viper/carbon/verifier/BoogieInterface.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@

package viper.carbon.verifier

import java.io._
import viper.carbon.boogie.{Assert, Program}
import viper.silver.reporter.BackendSubProcessStages._
import viper.silver.reporter.{BackendSubProcessReport, Reporter}
import viper.silver.verifier.errors.Internal
import viper.silver.verifier.reasons.InternalReason
import viper.silver.verifier.{Failure, _}
import viper.silver.verifier._

import java.io._
import scala.jdk.CollectionConverters._

class BoogieDependency(_location: String) extends Dependency {
Expand Down Expand Up @@ -174,6 +174,15 @@ trait BoogieInterface {
_boogieProcess = Some(proc)
_boogieProcessPid = Some(proc.pid)


//proverShutDownHook approach taken from Silicon's codebase
val proverShutdownHook = new Thread {
override def run(): Unit = {
destroyProcessAndItsChildren(proc, boogiePath)
}
}
Runtime.getRuntime.addShutdownHook(proverShutdownHook)

proc.getOutputStream.close()

// _z3ProcessStream = Some(proc.descendants().toScala(LazyList))
Expand All @@ -189,7 +198,16 @@ trait BoogieInterface {
errorStreamThread.start()
inputStreamThread.start()

proc.waitFor()
try {
proc.waitFor()
} finally {
destroyProcessAndItsChildren(proc, boogiePath)
}

// Deregister the shutdown hook, otherwise the prover process that has been stopped cannot be garbage collected.
// Explanation: https://blog.creekorful.org/2020/03/classloader-and-memory-leaks/
// Bug report: https://github.com/viperproject/silicon/issues/579
Runtime.getRuntime.removeShutdownHook(proverShutdownHook)

errorStreamThread.join()
inputStreamThread.join()
Expand All @@ -205,19 +223,19 @@ trait BoogieInterface {
}
}

private def destroyProcessAndItsChildren(proc: Process, processPath: String) : Unit = {
if(proc.isAlive) {
reporter report BackendSubProcessReport("carbon", processPath, BeforeTermination, _boogieProcessPid)
proc.children().forEach(_.destroy() : Unit)
proc.destroy()
reporter report BackendSubProcessReport("carbon", processPath, AfterTermination, _boogieProcessPid)
}
}

def stopBoogie(): Unit = {
_boogieProcess match {
case Some(proc) =>
reporter report BackendSubProcessReport("carbon", boogiePath, BeforeTermination, _boogieProcessPid)
proc.destroy()
/*_z3ProcessStream match {
case Some(stream) =>
stream.foreach((ph: ProcessHandle) => {
ph.destroy()
})
case None =>
}*/
reporter report BackendSubProcessReport("carbon", boogiePath, AfterTermination, _boogieProcessPid)
destroyProcessAndItsChildren(proc, boogiePath)
case None =>
}
}
Expand Down
⚡