Skip to content

Don't count expected errors towards numberOfErrorsToReport limit#620

Merged
JonasAlaif merged 8 commits into
masterfrom
refute
Jun 30, 2022
Merged

Don't count expected errors towards numberOfErrorsToReport limit#620
JonasAlaif merged 8 commits into
masterfrom
refute

Conversation

@JonasAlaif

Copy link
Copy Markdown
Contributor

@mschwerhoff mschwerhoff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like concise PRs :-)

@JonasAlaif

Copy link
Copy Markdown
Contributor Author

@mschwerhoff It seems that errorsReportedSoFar doesn't get reset between test runs, and so causes the refutation tests to fail. We should reset this number to 0 between tests; ideally somewhere here. Any idea how I can get access to the errorsReportedSoFar val from there?

@mschwerhoff

Copy link
Copy Markdown
Contributor

Not your fault, of course, but Verifier is not a StatefulComponent and should not have state that needs to be reset. BaseVerifier would probably be a better fit. Resetting should then happen in def reset().

@JonasAlaif JonasAlaif merged commit 3f84a2c into master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants