Add refutation support#583
Merged
Merged
Conversation
Aurel300
reviewed
Jun 7, 2022
mschwerhoff
reviewed
Jun 7, 2022
mschwerhoff
left a comment
Contributor
There was a problem hiding this comment.
Looks good, mostly a few minor comments.
mschwerhoff
approved these changes
Jun 25, 2022
mschwerhoff
left a comment
Contributor
There was a problem hiding this comment.
Looks good, modulo a few minor comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
refute exprstatement, which is anassert exprwith errors inverted and without assuming anything in the following statements (anassert exprassumesexprafterwards). That is, arefute exprdoes not report an error iff anassert exprwould. Note that this is not the same asassert !exprsince both asserts fail in the following snippet:One useful application is to check reachability (e.g. for identifying dead code) since all assertions pass in unreachable code (i.e.
refute falsewill only error in dead code).To workaround Silicon's
numberOfErrorsToReportlimit, this PR also adds anExpectFailinfo tag to be used on assertions which should not be counted towards the limit (see linked Silicon PR).ExpectFailshould be anabstract classinstead