Removing global state#635
Merged
Merged
Conversation
mschwerhoff
requested changes
Aug 30, 2022
mschwerhoff
left a comment
Contributor
There was a problem hiding this comment.
Thanks for removing the global state! Looks all good to me, modulo the few (and exciting) comments I left.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing global state in order to be able to run multiple instances of Silicon in parallel (which several frontends would like to do). Depends on Silver PR viperproject/silver#600
We're making the following changes:
Note that Verifier.config remains global, since I'm assuming that we don't want to run Silicon with different settings at the same time, and it's referenced all over the place