Removing global state#600
Merged
Merged
Conversation
Contributor
Author
|
@JonasAlaif So what do I do here now to get the backend tests to pass (since this PR depends on a Silicon PR viperproject/silicon#635 and vice versa)? |
Contributor
|
@marcoeilers merge the silicon PR first (also looks like you'll need to update carbon) and afterwards either a) rerun the tests here or b) just merge it without rerunning the tests since you saw that those tests passed in the silicon PR with the same version of silver |
jcp19
approved these changes
Sep 1, 2022
jcp19
left a comment
Contributor
There was a problem hiding this comment.
I am not super well-versed in this part of the code, so I would suggest waiting for another review before merging. From my side, I have some minor remarks
vakaras
approved these changes
Sep 1, 2022
vakaras
left a comment
Contributor
There was a problem hiding this comment.
The approach sounds good, but I am unfamiliar with the code to review it properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing global state from Silver in order to be able to run multiple instances of Silicon or Carbon in parallel (which several frontends would like to do).
In particular,
As a result, all code that used to directly access FastParser is now passed an instance of FastParser instead or has to create one itself. In particular, the interface of Viper plugins is extended s.t. their constructor now gets an additional FastParser argument.