Fix performance regression of AST traversal#493
Merged
Conversation
fpoli
force-pushed
the
optimize-iterator
branch
from
1f588a7 to
7bf9201
Compare
fpoli
changed the title
Member
Author
|
Malte's program now verifies in 20 seconds, as it used to be. The PR is ready to be merged. |
mschwerhoff
approved these changes
Feb 2, 2021
Contributor
That is great news, thank you. Looks ready to me as well. |
fpoli
force-pushed
the
optimize-iterator
branch
from
61ffb7a to
928cd15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mschwerhoff this makes the program that you sent me verify in 1m 30s.
The remaining slowdown are the allocations performed in the
iteratormethod, which put pressure on the GC.Update
I added a minimal
Traversabletrait to keep using the old (i.e. before 1df0f34) interface and implementation, which does not incur allocation costs.