Implement Iterable for ast.Node instead of a hand-crafted Traversable#497
Merged
Conversation
7277d52 to
c037504
Compare
mschwerhoff
reviewed
Feb 13, 2021
| trait Node extends Iterable[Node] with Rewritable { | ||
|
|
||
| /** @see [[Nodes.subnodes()]] */ | ||
| def subnodes = Nodes.subnodes(this) |
Contributor
There was a problem hiding this comment.
@fpoli If we bake in the assumption that all nodes are immutable, we could turn subnodes and iterator (and maybe other defs) into lazy vals. This could speed up subsequent traversals of the same tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @marcoeilers pointed out, PR #493 removed too many methods from the interface. Manually re-implementing all of them in the
utils.Traversabletrait is a lot of work. This PR provides a different trade-off between performance and usability.Pro:
ast.Nodeextends again theIterabletrait, so it inherits all its convenient methods.foreachjust calls the visitor and is thus efficient.iterator's implementation just allocates one collection containing all the AST's subnodes, rather than doing it for each node of the AST.Cons:
ast.Nodewill internally calliterator, thus they'll create a collection containing all the AST's subnodes. In most of the cases, the allocation can be avoided by overriding the method such that it internally usesforeachinstead ofiterator.