cgen: unwrap and c-mangle field selectors in or blocks#17495
Merged
spytheman merged 2 commits intovlang:masterfrom Mar 4, 2023
Merged
cgen: unwrap and c-mangle field selectors in or blocks#17495spytheman merged 2 commits intovlang:masterfrom
spytheman merged 2 commits intovlang:masterfrom
Conversation
Delta456
approved these changes
Mar 3, 2023
Contributor
|
The CI failure is unrelated (it is a timed out slow running github job). |
l1mey112
pushed a commit
to l1mey112/v
that referenced
this pull request
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the case where C keywords are not correctly mangled in field selectors with or blocks.
The following code otherwise generates invalid C:
The following C code is generated:
There is no open ticket for this issue (that I'm aware of).
PR includes test.