facts.pp: use localhost instead of 127.0.0.1#338
Merged
kenyon merged 3 commits intovoxpupuli:masterfrom Mar 5, 2021
Merged
Conversation
kenyon
force-pushed
the
fact-file-fixes
branch
2 times, most recently
from
029f513 to
7fbb7b3
Compare
ekohl
approved these changes
Feb 10, 2021
Member
Author
|
Needs #340 for the tests to pass. |
kenyon
force-pushed
the
fact-file-fixes
branch
from
7fbb7b3 to
d2d63f2
Compare
kenyon
changed the title
Member
Author
|
I split this PR into separate PRs so that we produce a better changelog. |
ekohl
reviewed
Feb 14, 2021
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
We should also squash commits to keep the history a bit cleaner.
kenyon
force-pushed
the
fact-file-fixes
branch
2 times, most recently
from
f697d0d to
6ec41c2
Compare
ekohl
reviewed
Mar 1, 2021
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Could you rebase this now that modulesync was merged?
Member
|
I opened #347. Can we merge that first and then rebase this on top of it? |
Member
|
I opened #349 to fix the tests |
This way we don't discriminate against IPv6-only configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use localhost instead of 127.0.0.1 so that we don't discriminate against IPv6-only configurations.