Remove special code path for Puppet Enterprise#347
Merged
kenyon merged 1 commit intovoxpupuli:masterfrom Mar 1, 2021
Merged
Conversation
On Puppet Enterprise the aio_agent_version fact should also be set so it's redundant. The json_packages code is made generic so it's executed on all non-AIO installs.
kenyon
approved these changes
Mar 1, 2021
Member
|
Oh, looks like the tests didn't run for this. It looked good when I merged it, but the GitHub interface must have deceived me somehow. |
Member
Author
|
Hmm, that is odd. Looks like it was never triggered and we don't have a required check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Puppet Enterprise the aio_agent_version fact should also be set so it's redundant.
The json_packages code is made generic so it's executed on all non-AIO installs.