Convert mongoshrc.js template to EPP#790
Merged
kenyon merged 3 commits intovoxpupuli:masterfrom Mar 1, 2026
Merged
Conversation
kenyon
changed the title
mongorc.js template to EPP
Unwrapping a plain string just returns the string, so no need to check if it's sensitive.
Unwrapping a plain string just returns the string, so no need to check if it's sensitive.
kenyon
changed the title
mongorc.js template to EPPmongoshrc.js template to EPP
kenyon
force-pushed
the
simplify-sensitive-handling
branch
from
5cf15b5 to
5383c11
Compare
kenyon
force-pushed
the
simplify-sensitive-handling
branch
from
5383c11 to
ca4080b
Compare
bastelfreak
approved these changes
Mar 1, 2026
bastelfreak
added
enhancement
cocker-cc
reviewed
Mar 1, 2026
| user => $admin_username, | ||
| auth_mechanism => $admin_auth_mechanism, | ||
| password => $admin_password_unsensitive, | ||
| password => $admin_password.unwrap, |
Contributor
There was a problem hiding this comment.
Why unwrap here, although mongodb::db accepts Sensitive?
unwrap should be the absolute Exception!
Member
Author
There was a problem hiding this comment.
Because I was just removing the unnecessary unwrap logic above. We could push the unwrap into mongodb::db, looks like that would be equivalent. Looks like it still needs to be unwrapped for use in mongodb_user. @cocker-cc do you want to provide a PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$admin_password_unsensitivelogicmongoshrc.jstemplate to EPP