Remove Excessive Scoping Rules on Local Variables

[fubuloubu]

fixes: #2127

Description for the changelog

No longer throws when a local variable has the same name as a global, due to the namespacing by self.

Cute Animal Picture

[codecov-commenter]

Codecov Report

Merging #2166 into master will increase coverage by 0.95%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2166      +/-   ##
==========================================
+ Coverage   84.26%   85.22%   +0.95%     
==========================================
  Files          83       83              
  Lines        8337     8330       -7     
  Branches     2012     2009       -3     
==========================================
+ Hits         7025     7099      +74     
+ Misses        809      731      -78     
+ Partials      503      500       -3     

Impacted Files	Coverage Δ
vyper/context/validation/local.py	88.23% <100.00%> (-0.15%)	⬇️
vyper/parser/context.py	93.25% <100.00%> (+2.04%)	⬆️
vyper/parser/global_context.py	77.77% <100.00%> (+0.81%)	⬆️
vyper/ast/nodes.py	93.84% <0.00%> (+1.53%)	⬆️
vyper/parser/expr.py	76.76% <0.00%> (+4.97%)	⬆️
vyper/functions/functions.py	89.71% <0.00%> (+5.34%)	⬆️
vyper/context/types/value/numeric.py	84.14% <0.00%> (+6.09%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 958a183...d459388. Read the comment docs.

[isavelli]

Here https://vyper.readthedocs.io/en/latest/scoping-and-declarations.html?highlight=shadow#name-shadowing
it still says:

It is not permitted for a memory or calldata variable to shadow the name of a storage variable.

I guess the reference to calldata should be removed given this merge?

[fubuloubu]

Here https://vyper.readthedocs.io/en/latest/scoping-and-declarations.html?highlight=shadow#name-shadowing it still says:

It is not permitted for a memory or calldata variable to shadow the name of a storage variable.

I guess the reference to calldata should be removed given this merge?

Yes! Can you submit a PR please?

[isavelli]

No idea how to do :) Also, about the return statement https://vyper.readthedocs.io/en/latest/statements.html?highlight=return#return, the guide states that all functions must end with it, but the compiler seems fine if no return is provided.