Lift restriction on calldata variables shadowing storage variables#2226
Merged
fubuloubu merged 2 commits intoNov 27, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2226 +/- ##
==========================================
+ Coverage 85.32% 85.34% +0.01%
==========================================
Files 84 84
Lines 8533 8528 -5
Branches 2064 2061 -3
==========================================
- Hits 7281 7278 -3
+ Misses 745 744 -1
+ Partials 507 506 -1
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Nov 27, 2020
6af6fa2 to
23db60d
Compare
fubuloubu
approved these changes
Nov 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Lift a restriction preventing calldata variable names from shadowing storage variable names.
Related to #2166
Fixes #2219
How I did it
Remove the checks in
contextandparsersubpackages.How to verify it
Run tests.
Cute Animal Picture