[SubtitleSampleReader] Fix packet pts#1907
Merged
CastagnaIT merged 2 commits intoxbmc:Piersfrom Sep 17, 2025
Merged
Conversation
When ReadFull return false can be for multiple reasons, e.g. if a stream have few subs segments lead to finish in ahead of the video, so print this error is wrong. In case of download error will be already printed on log
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
i suspect a regression of PR #1890
that solved the problem of wrong pts comparisons on
CSession::GetNextSamplelooks like that the use of PTSDiff is not needed anymore since
CSession::GetNextSamplenow use "manifest based" ptsi hope this dont cause sideeffects on other subs use cases, touch this code cause always headaches due to difficult in testing all cases
Motivation and context
@cscd98 reported privately that D+ has again subtitle problems
NOTE: D+ have use case of segmented webvtt, on multiple periods
i realized that the problem can be reproduced this way:
play video->enable subs from GUI->seek video back of some time->after the seek the subs segments are initially downloaded but not sent to kodi demuxer ofc subs are now broken
How has this been tested?
The only stream i found affected with this similar problem is
HLS "daserste ARD" tv live stream
and to test HLS multiperiods subs, i used my local test stream "Akmai"
D+ confirmed by cscd98
Screenshots (if appropriate):
Types of change
Checklist: