Skip to content

[ISampleReader] Removed SetPTSDiff method#1996

Merged
CastagnaIT merged 1 commit intoxbmc:Piersfrom
CastagnaIT:seek_ptsdiff
Feb 16, 2026
Merged

[ISampleReader] Removed SetPTSDiff method#1996
CastagnaIT merged 1 commit intoxbmc:Piersfrom
CastagnaIT:seek_ptsdiff

Conversation

@CastagnaIT
Copy link
Copy Markdown
Collaborator

@CastagnaIT CastagnaIT commented Feb 16, 2026

Description

after old PR #1907 SetPTSDiff method is no longer used since it is noop
since the mentioned PR at today no reports of subtitles malfunctions due to that code change
so lets remove this code

Motivation and context

cleanup

How has this been tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v22 Piers labels Feb 16, 2026
@kodiai
Copy link
Copy Markdown

kodiai Bot commented Feb 16, 2026

Review Details
  • Files reviewed: 2
  • Lines changed: +0 -3
  • Profile: strict (auto, lines changed: 3)
  • Author: core (adapted tone)
  • Findings: 0 critical, 0 major, 0 medium, 0 minor
  • Review completed: 2026-02-16T13:41:04.552Z
  • Keyword parsing:
    • ignored [isamplereader]
    • breaking change in body

@CastagnaIT CastagnaIT merged commit e8e47b4 into xbmc:Piers Feb 16, 2026
12 checks passed
@CastagnaIT CastagnaIT deleted the seek_ptsdiff branch February 16, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v22 Piers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant