Conversation
By default, state.donor and state.forum are `null`, but `null != ""`, so the `null` gets copied into the stripe request and converted to the string `null`. Work around this by defaulting to `""`.
Closed
pkscout
approved these changes
Jun 6, 2021
razzeee
reviewed
Jun 6, 2021
| ], | ||
| mode: "subscription", | ||
| clientReferenceId: props.donorname + sep + props.forumname, | ||
| clientReferenceId: (props.donorname || "") + sep + (props.forumname || ""), |
Member
There was a problem hiding this comment.
While this is fine, you might want to use ?? in the future, as there is a slight difference.
Member
Author
There was a problem hiding this comment.
Thanks for the hint, I don't have that much JS experience. What would the difference be in this case?
Member
There was a problem hiding this comment.
Please see the example at https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#nullish-coalescing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, state.donor and state.forum are
null, butnull != "", so thenullgets copied into the stripe request and converted to the stringnull. Work around this by defaulting to"".