Return different writable streams depending on whether writing without response is permitted#19
Open
agrippa wants to merge 3 commits intozmkfirmware:mainfrom
Open
Return different writable streams depending on whether writing without response is permitted#19agrippa wants to merge 3 commits intozmkfirmware:mainfrom
agrippa wants to merge 3 commits intozmkfirmware:mainfrom
Conversation
…t response is permitted
| }, | ||
| }); | ||
|
|
||
| return { label, readable, |
Contributor
There was a problem hiding this comment.
Can we defer creation of the two writables until this ternary resolves, to avoid the spurious object creation?
Author
There was a problem hiding this comment.
just made an update, how does that look?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When constructing a new transport, it seems that on some systems writing without a response is not permitted (based on the writeWithoutResponse property: https://developer.mozilla.org/en-US/docs/Web/API/BluetoothCharacteristicProperties).
This PR retains the current default behavior (without response) for boards that support it, but adds support for boards where this is not enabled.