Skip to content

Return different writable streams depending on whether writing without response is permitted #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agrippa wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Return different writable streams depending on whether writing without response is permitted #19

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63084e0
Return different writable streams depending on whether writing withou…
agrippa Aug 17, 2024
f0b6fbc
defer object creation
agrippa Aug 17, 2024
7809a7d
better indentation
agrippa Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/transport/gatt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export async function connect(): Promise<RpcTransport> {
// Reconnect to the same device will lose notifications if we don't first force a stop before starting again.
await char.stopNotifications();
await char.startNotifications();

let vc = (ev: Event) => {
let buf = (ev.target as BluetoothRemoteGATTCharacteristic)?.value
?.buffer;
Expand All @@ -47,14 +48,22 @@ export async function connect(): Promise<RpcTransport> {
};

dev.addEventListener('gattserverdisconnected', cb);

},
});

let writable = new WritableStream({
let writableWithoutResponse = new WritableStream({
write(chunk) {
return char.writeValueWithoutResponse(chunk);
},
});

return { label, readable, writable };
let writableWithResponse = new WritableStream({
write(chunk) {
return char.writeValueWithResponse(chunk);
},
});

return { label, readable,
Copy link
Copy Markdown
Contributor

@petejohanson petejohanson Aug 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we defer creation of the two writables until this ternary resolves, to avoid the spurious object creation?

Copy link
Copy Markdown
Author

@agrippa agrippa Aug 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just made an update, how does that look?

writable: char.properties.writeWithoutResponse ? writableWithoutResponse : writableWithResponse };
}
⚡