Workload Identity support#266
Merged
lonegunmanb merged 3 commits intoAzure:masterfrom Oct 18, 2022
Merged
Conversation
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
lonegunmanb
requested changes
Oct 17, 2022
Member
lonegunmanb
left a comment
lonegunmanb
left a comment
There was a problem hiding this comment.
Thanks @nlamirault for opening this pr. We're introduced a CI pipeline for this module and now we're enforcing some code style policies. You can check whether your pr meets the requirement by reading this document and run the make pr-check command. Thanks for your understanding.
| default = false | ||
| } | ||
|
|
||
| variable "workload_identity_enabled" { |
Member
There was a problem hiding this comment.
Could we reorder variables in alphabet order please? Thanks.
| local_account_disabled = var.local_account_disabled | ||
| node_resource_group = var.node_resource_group | ||
| oidc_issuer_enabled = var.oidc_issuer_enabled | ||
| workload_identity_enabled = var.workload_identity_enabled |
Member
There was a problem hiding this comment.
Could we reorder arguments in alphabet order please? Thanks.
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
lonegunmanb
approved these changes
Oct 18, 2022
Member
lonegunmanb
left a comment
lonegunmanb
left a comment
There was a problem hiding this comment.
Thanks @nlamirault , LGTM.
This was referenced Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
azurerm_kubernetes_cluster- addworkload_identity_enabledproperty hashicorp/terraform-provider-azurerm#18742