Add support for pod subnet#271
Merged
lonegunmanb merged 4 commits intoAzure:masterfrom Nov 11, 2022
mr-onion-2:master
Merged
Conversation
added 2 commits
October 25, 2022 20:41
lonegunmanb
requested changes
Nov 1, 2022
Contributor
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
Contributor
|
MAIN BRANCH PUSH DETECTED DUE TO #272, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
Contributor
|
MAIN BRANCH PUSH DETECTED DUE TO #273, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
Contributor
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
Member
|
@mr-onion-2 sorry for the late reply, our test infrastructure was broken last week, and we've just fixed it. We've changed the test runner's pool name, would you please rebase this pr with the latest master branch so our new test pipeline can run the test? Apology for your inconveniency and thanks for your understanding. |
From main repo
lonegunmanb
approved these changes
Nov 11, 2022
Member
lonegunmanb
left a comment
lonegunmanb
left a comment
There was a problem hiding this comment.
Thanks @mr-onion-2 , LGTM!
This was referenced Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for pod_subnet_id