Skip to content

[release-0.6] backports for 0.6.0-rc3#22199

Merged
tkelman merged 73 commits intorelease-0.6from
tk/backports-0.6.0-rc3
Jun 7, 2017
Merged

[release-0.6] backports for 0.6.0-rc3#22199
tkelman merged 73 commits intorelease-0.6from
tk/backports-0.6.0-rc3

Conversation

@tkelman
Copy link
Copy Markdown
Contributor

@tkelman tkelman commented Jun 3, 2017 •
edited
Loading

  • @nanosoldier runbenchmarks(ALL, vs = ":release-0.6") vs rc2
  • build:dog:
  • pkgeval

yuyichao and others added 30 commits June 2, 2017 07:51
@yuyichao @tkelman
Fix pool lookup function
1508d44 
(cherry picked from commit 1bb28ec)
ref #21924
@tkelman
Use cached urls for appveyor and contrib/prepare_release.sh
9f699ba 
downloads of nightlies

(cherry picked from commit 4db8fba)
ref #21927
@JeffBezanson @tkelman
fix #21923, regressions in circular type definitions
5c1a88c 
(cherry picked from commit 49d130c)
ref #21928
@Sacha0 @tkelman
Add NEWS.md entry for arithtype deprecation (#18218). (#21942)
758c817 
(cherry picked from commit 6ba63e5)
@Sacha0 @tkelman
Fix PR number in NEWS.md entry for num/den rename (#19246). (#21943)
fb3cdff 
(cherry picked from commit b94cca1)
@Sacha0 @tkelman
Add NEWS.md entry for zero-arg Channel constructor dep (#18832). (#21932
effa3bb 
)

(cherry picked from commit a72aad4)
@Sacha0 @tkelman
Add NEWS.md entry for promote_op(::Type, Ts...) deprecation (#18642). (…
2ec983d 
…#21931)

(cherry picked from commit 907afec)
@ararslan @tkelman
Use isbindingresolved when checking imported packages (#21580)
2b4d7fe 
(cherry picked from commit d762038)
@Sacha0 @tkelman
Mention SharedArrays constructor deps in NEWS.md entry for #19989. (#…
2d9d5d3 
…21995)

(cherry picked from commit e68690d)
@Sacha0 @tkelman
Add NEWS.md entry for midpoints deprecation (#20058). (#21930)
dda1373 
(cherry picked from commit f988566)
@yuyichao @tkelman
Fix fallthrough warning on gcc 7
787bf7b 
(cherry picked from commit 6e8a1e3)
ref #22001
@duguxy @tkelman
Wrong parameter names for sygvd! in the document (#22035)
6b1f257 
(cherry picked from commit 0b49fd5)
@Sacha0 @tkelman
Add NEWS.md entry for dep of getindex(::Tuple, ::AbstractArray{_,N}) …
0b1e4ef 
…where N>1 (#19737). (#21988)

(cherry picked from commit 3c5c27a)
@vtjnash @tkelman
fix jl_gc_realloc_string size miscomputation
544694a 
fix #22021

(cherry picked from commit df3cd1c)
ref #22044
@vchuravy @tkelman
limit maximum vector alignment to heap alignment
a8c6e6d 
(cherry picked from commit c2c0997)
ref #21980

introduce jl_datatype_align

(cherry picked from commit 5115a38)

Introduce JL_HEAP_ALIGNMENT

(cherry picked from commit ed286e4)

fix julia_alignment

Make julia_alignment actually return the jl_datatype_align if
`alignment == 0` and check that the requested alignment is coherent
with the heap alignment.

(cherry picked from commit b9671b0)
@fredrikekre @tkelman
document AbstractArray and doctest for Array (#22052)
8d66dbd 
(cherry picked from commit 888adbc)
@yuyichao @tkelman
Do not reinterpret to wrong alignment
7612502 
This is undefined behavior in LLVM and can actually segfault on real hardware
including x86 in certain cases.

Also add missing endianess test since it is changed in this commit.

(cherry picked from commit 99286f9)
ref #21831
@fredrikekre @tkelman
Fix @deprecate with the new where syntax (#22034)
cb78b63 
* fix at-deprecate with where syntax

* tests for at-deprecate

(cherry picked from commit 215adb2)
@Sacha0 @tkelman
Add PR number and quotes to NEWS.md entry for #18754. (#21842)
acf0c7c 
(cherry picked from commit e020772)
@Sacha0 @tkelman
Add NEWS.md entry for promote_eltype_op deprecation (#19814, #19937). (…
9129a3c 
…#21992)

(cherry picked from commit 152d255)
@Sacha0 @tkelman
Add NEWS.md entry for enumerate(::IndexStyle, itr) addition and index…
6b7f68b 
…ing traits rename (#16378). (#21997)

(cherry picked from commit 18d7af8)
@Sacha0 @tkelman
Fix typo in NEWS.md entry for midpoints deprecation (#20058). (#22008)
aea6a50 
(cherry picked from commit 9ba1b49)
@Sacha0 @tkelman
Add NEWS.md entry for _promote_array_type deprecation (#19766). (#21990)
57ea815 
(cherry picked from commit b77a688)
@Sacha0 @tkelman
Add NEWS.md entry for unsafe_wrap(String, ...) deprecation (#19449). (#…
9851e79 
…21993)

(cherry picked from commit a4bafff)
@Sacha0 @tkelman
Add NEWS.md entry for takebuf_{array|string} deprecation (#19088). (#…
8479b7b 
…21975)

(cherry picked from commit b7fdf5c)
@Sacha0 @tkelman
Add PR number to NEWS.md entry for cummin/cummax deprecation (#18931). (
f9fb392 
#21987)

(cherry picked from commit d74dbd7)
@tkelman
Fix opensuse repo links for make win-extras (#22058)
eda7690 
(cherry picked from commit 4158b5e)
@mortenpi @tkelman
Use julia-repl in documentation
8520a55 
With the highlighting updates in Documenter v0.10.1 it is now possible
to have specialized highlighting for REPL blocks via the julia-repl
attribute on code blocks. Doctests already use this, so this makes the
highlighting for non-doctest REPL blocks consistent.

(cherry picked from commit 014c5d5)
ref #21866

Use at-repl for versioninfo() output

(cherry picked from commit f67d4fd)

Enable highlighting in the manual

A couple of code examples were not highlighted for some reason.

(cherry picked from commit b710de9)

Remove highlighting from REQUIRE code

These blocks are not Julia code, but special REQUIRE file syntax
instead.

(cherry picked from commit c90c17f)

Enable bash highlighting

Also add a newline to the end of the file.

(cherry picked from commit 6e08c18)

Use a non-deprecated package in an example

UTF16.jl has been deprecated for a while. Use SHA.jl instead as the
example.

(cherry picked from commit 6e5c55d)

Edit manual/conversion-and-promotion.md

The REPL example is basically exactly as above, and does not add
anything to the latter bit about the actual convert methods.

(cherry picked from commit 96b65f1)

Fix line numbers in doctests

(cherry picked from commit 814a8a1)

Enable a doctest in base/regex.jl

(cherry picked from commit d9063cb)

Enable doctests the the manual

Switching to julia-repl revealed several code blocks that could
trivially be turned into doctests.

(cherry picked from commit 1d20519)
@KristofferC @tkelman
check that reinterp on vector of tuples doesnt segfault
da81858 
(cherry picked from commit 53ea47e)
ref #22066
@giordano @tkelman
Fix complex exp2 and exp10 with boolean and irrational argument (#21874)
a4f54e8 
Fix #21200.
(cherry picked from commit 03639b9)
@yuyichao
Copy link
Copy Markdown
Contributor

yuyichao commented Jun 3, 2017

Edited out the one in the top post. Let's see if it helps....

@nanosoldier
Copy link
Copy Markdown
Collaborator

nanosoldier commented Jun 3, 2017

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@jlbuild
Copy link
Copy Markdown

jlbuild commented Jun 3, 2017 •
edited
Loading

Status of ea1cc8f builds:

Builder Name Nuke Build Download Code Output
linux32 COMPLETE COMPLETE Download ERRORED
linux64 COMPLETE COMPLETE Download COMPLETE
linuxaarch64 COMPLETE COMPLETE Download ERRORED
linuxarmv7l COMPLETE COMPLETE Download ERRORED
linuxppc64le COMPLETE COMPLETE Download ERRORED
osx64 COMPLETE COMPLETE Download PENDING
win32 PENDING N/A N/A N/A
win64 COMPLETE ERRORED N/A N/A

@tkelman tkelman mentioned this pull request Jun 3, 2017
Merged
@tkelman tkelman force-pushed the tk/backports-0.6.0-rc3 branch from ea1cc8f to ac35d0f Compare June 3, 2017 23:34
@tkelman
Copy link
Copy Markdown
Contributor Author

tkelman commented Jun 5, 2017

pkgeval results: https://gist.github.com/62d8d15eee91ce2332322a54fee0bffa

several 0.6-only package versions now have UndefVarErrors because of the scope change

InformationMeasures has a flaky tolerance, JuMP timed out

Unitful has an inference regression that needs bisecting

@tkelman
Copy link
Copy Markdown
Contributor Author

tkelman commented Jun 5, 2017

The backport of #21771 broke Unitful so will get reverted unless there's a better fix proposed immediately, sorry @andyferris. It's also failing on master, so needs a fix anyway.

JeffBezanson and others added 7 commits June 5, 2017 19:35
@JeffBezanson @tkelman
fix #22164 and #22002, method sorting problems
56b68d9 
fix #22164, specificity issue in ForwardDiff

(cherry picked from commit e92eb58)
partial backport of #22162
@tkelman
Merge pull request #22206 from JuliaLang/jb/fix22002
567488c 
[release-0.6] fix #22164 and #22002, method sorting problems
@yuyichao @tkelman
Backport LLVM patches to fix AVX on i686
afb642e 
This fixes a bug in the patch that fixes #19976 causing encoding error on 32bit x86
and segfault when AVX/AVX2 is enabled.

Ref LLVM bug report https://bugs.llvm.org//show_bug.cgi?id=29010
LLVM commit llvm-mirror/llvm@83260f2
Also ref where I saw this issue in #21849 (comment)

(cherry picked from commit 5a42474)
ref #22205
@mortenpi @tkelman
Work around linkcheck errors in docs (#22201)
8cd6ad2 
(cherry picked from commit 39777e7)
@omus @tkelman
Fix DomainError when parsing DateTime (#22198)
7c0a1b7 
* Fix DomainError when parsing DateTime

* Converted tests into a testset

(cherry picked from commit abf3bce)
@sunoru @tkelman
fix #22168, im*I+I should be shown as (1+1im)*I (#22169)
917f80e 
* fix #22168, `im*I+I` should be shown as `(1+1im)*I`

* add test for `show(UniformScaling)`

* check the number of terms in `show(::UniformScaling)`

* fix the misuse of `|`

(cherry picked from commit e9b73ec)
@tkelman
Use libgcc dlls from build system compiler (#22197)
73b5504 
instead of opensuse
(cherry picked from commit 5aa15ff)
@tkelman
Copy link
Copy Markdown
Contributor Author

tkelman commented Jun 6, 2017

probably no change but just in case
@nanosoldier runbenchmarks(ALL, vs = ":release-0.6")
@jlbuild !nuke

Base.runtests()
Base.runtests("pkg libgit2-online download")

I think the file test failure on some of the build workers might be if they don't have curl (or wget?) installed

@jlbuild
Copy link
Copy Markdown

jlbuild commented Jun 6, 2017 •
edited
Loading

Status of e531c84 builds:

Builder Name Nuke Build Download
linux32 COMPLETE COMPLETE Download
linux64 COMPLETE COMPLETE Download
linuxaarch64 COMPLETE COMPLETE Download
linuxarmv7l COMPLETE COMPLETE Download
linuxppc64le COMPLETE COMPLETE Download
osx64 COMPLETE COMPLETE Download
win32 CANCELED N/A N/A
win64 COMPLETE ERRORED N/A

@andyferris
Copy link
Copy Markdown
Member

andyferris commented Jun 6, 2017

The backport of #21771 broke Unitful so will get reverted unless there's a better fix proposed immediately, sorry @andyferris. It's also failing on master, so needs a fix anyway.

@vtjnash Do you understand this, Jameson? Is the Unitful problem to do with the changes to inference, or the changes to promotion?

@vtjnash
Copy link
Copy Markdown
Member

vtjnash commented Jun 6, 2017

It's a bug in Unitful that was being hidden by your fix.

@vtjnash
Copy link
Copy Markdown
Member

vtjnash commented Jun 6, 2017

Unitful bug fixed by JuliaPhysics/Unitful.jl#89

@tkelman tkelman mentioned this pull request Jun 6, 2017
Merged
@andyferris
Copy link
Copy Markdown
Member

andyferris commented Jun 6, 2017

Awesome. Sounds like we should include #21771 here after all, @tkelman.

@nanosoldier
Copy link
Copy Markdown
Collaborator

nanosoldier commented Jun 6, 2017

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@tkelman tkelman force-pushed the tk/backports-0.6.0-rc3 branch from e531c84 to 73b5504 Compare June 6, 2017 04:42
@timholy timholy mentioned this pull request Jun 7, 2017
Closed
@tkelman
Copy link
Copy Markdown
Contributor Author

tkelman commented Jun 7, 2017

Ran pkgeval again with the latest few additional commits: https://gist.github.com/105a392d802f96abd017cbb747d5696d

Same scope issues in DeepDiffs, PortAudio, RingBuffers, and SimilaritySearch. ImageView failure wasn't happening in the last run, but I think the InexactError is an intermittent numerical problem that has happened on rc2 as well: https://github.com/JuliaCI/pkg.julialang.org/blob/cfad0830fc32634fa83e6c587ff9d79f0eba4ce8/logs/ImageView_0.6.log

In the interest of getting this rc out I'll merge and tag here, there are a few more backport-worthy bugfixes over the last day but some of them still need tests.

@tkelman tkelman merged commit f90acdc into release-0.6 Jun 7, 2017
@tkelman tkelman deleted the tk/backports-0.6.0-rc3 branch June 7, 2017 11:52
@tkelman
Copy link
Copy Markdown
Contributor Author

tkelman commented Jun 7, 2017

DeepDiffs and RingBuffers issues were very simple fixes ssfrr/DeepDiffs.jl#7 and JuliaAudio/RingBuffers.jl#6, no change is needed in PortAudio it just needs the RingBuffers fix to get released

@davidanthoff
Copy link
Copy Markdown
Contributor

davidanthoff commented Jun 7, 2017

Great! Can you post a message on discourse once the binaries are out so that lots of people will test this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.
⚡