Conversation
duranb
requested review from
AaronPlave,
dandelany,
joswig,
mattdailis and
srschaffJPL
add simulation args to plan import
duranb
force-pushed
the
feature/plan-import
branch
from
5f08dae to
528fb1b
Compare
Mythicaeda
reviewed
Jul 24, 2024
Mythicaeda
added
the
breaking change
dandelany
approved these changes
Jul 24, 2024
Collaborator
dandelany
left a comment
dandelany
left a comment
There was a problem hiding this comment.
Thanks all - I think all blockers from @Mythicaeda above have been addressed and we'll handle the others in a later release - I agree that both the bulk insert & transactions proposals are worth doing in future. I've tested this a bit more with @duranb using Banananation as well as some other plans provided by Brad, and everything behaved as expected. Approving this for release in 2.16.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1154
Refer to NASA-AMMOS/plandev-ui#1388 for testing procedure.
This adds a new
/importPlanroute for plan import as well as creates a new process that hopefully speeds up local development.The new
devnpm script watches for code changes and automatically rebuilds and deploys the server.