Conversation
AaronPlave
reviewed
Jul 23, 2024
AaronPlave
reviewed
Jul 23, 2024
Contributor
|
This is something that could be done in a follow-up PR but could we add an e2e test that performs download, checks output against plan, upload, checks plan against old plan and json, etc? |
duranb
force-pushed
the
feature/plan-import
branch
from
085d5c6 to
4ec74b8
Compare
duranb
force-pushed
the
feature/plan-import
branch
from
4ec74b8 to
58c494b
Compare
AaronPlave
approved these changes
Jul 24, 2024
duranb
force-pushed
the
feature/plan-import
branch
from
58c494b to
d505ec7
Compare
dandelany
approved these changes
Jul 25, 2024
Collaborator
dandelany
left a comment
dandelany
left a comment
There was a problem hiding this comment.
👍 thanks @duranb - as mentioned in the gateway ticket we did some further testing of this and all looked good. Added some docs in this PR: NASA-AMMOS/aerie-docs#176
I'll go ahead and merge this for the 2.16 release.
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
* add support for plan import * update PlanTransfer schema to include sim args and tag colors * export activity tags * fix test * derive end time from planJSON duration * parse both DOY and YMD from plan file * make tags optional * import times as UTC * sort directives by id on export * another fix for UTC import parsing
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* add support for plan import * update PlanTransfer schema to include sim args and tag colors * export activity tags * fix test * derive end time from planJSON duration * parse both DOY and YMD from plan file * make tags optional * import times as UTC * sort directives by id on export * another fix for UTC import parsing
dandelany
pushed a commit
that referenced
this pull request
Aug 14, 2025
* add support for plan import * update PlanTransfer schema to include sim args and tag colors * export activity tags * fix test * derive end time from planJSON duration * parse both DOY and YMD from plan file * make tags optional * import times as UTC * sort directives by id on export * another fix for UTC import parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1154
Requires gateway PR: NASA-AMMOS/plandev-gateway#97
This feature implementation is purely functional and does not include any design considerations yet.
To test:
Export Planicon button at the top right of the panelImport Plan JSON Filefield and select the plan file that was downloaded in step 3Createbutton