util/xs_scripts/parallel_sim.sh (2)

34-40: Fix shell quoting and declare-assign separation issues.

Shellcheck flags several issues with command substitution quoting (SC2046, SC2155):

• Line 35-36: gem5_home assignment has unquoted command substitution; should declare and assign separately
• Line 38: gem5 assignment has unquoted realpath output; should quote the expansion

While these paths are unlikely to contain spaces in practice, quoting prevents word-splitting vulnerabilities and follows shell best practices.

Apply this diff:

-export gem5_home=$(dirname $(dirname $script_dir))
-export GEM5_BUILD_TYPE=${GEM5_BUILD_TYPE:-opt}
-export gem5=$(realpath $gem5_home/build/RISCV/gem5.$GEM5_BUILD_TYPE)
+script_dir=$(dirname -- "$( readlink -f -- "$0"; )")
+gem5_home=$(dirname "$(dirname "$script_dir")")
+export gem5_home
+export GEM5_BUILD_TYPE=${GEM5_BUILD_TYPE:-opt}
+gem5=$(realpath "$gem5_home/build/RISCV/gem5.$GEM5_BUILD_TYPE")
+export gem5

---

116-125: Quote variables in config mode execution.

Line 123 does not quote $extra_gem5_args. While this works for the current use case (single flags like --disable-mgsc), quoting would improve robustness against edge cases with spaces or special characters.

Apply this diff:

     if [ "$use_legacy_mode" = true ]; then
         # Legacy mode: call wrapper script
-        bash $arch_script $1 # checkpoint
+        bash "$arch_script" "$1" # checkpoint
         check $?
     else
         # New mode: directly call gem5 with config file
         # config_file is already an absolute path from realpath
-        $gem5 $config_file --generic-rv-cpt=$1 $extra_gem5_args
+        "$gem5" "$config_file" --generic-rv-cpt="$1" $extra_gem5_args
         check $?
     fi

Note: $extra_gem5_args is intentionally left unquoted to allow multiple space-separated arguments to expand correctly, as they are already properly delimited by the template and shell parsing.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro