util: update README and rename CI configs[skip ci]#647
Conversation
WalkthroughThis pull request updates a GEM5 CI workflow configuration file for BTB performance testing, renaming the workflow and adjusting trigger conditions to target specific branches. Manual workflow dispatch is enabled. Corresponding documentation is added describing Kunminghu configuration variants and their CI coverage. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Change-Id: If6f28d0ac57d57e07b716241136d106217123c72
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/gem5-ideal-btb-0.3c.yml (1)
8-13: Thebranch_nameinput is defined but never used in the workflow.The
workflow_dispatchinputbranch_name(lines 10-12) is not referenced anywhere. The reusable workflow call (lines 17-19) does not pass this input, so the workflow will execute against the current branch regardless of what the user provides. Either pass this input to the reusable workflow call or remove it.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/gem5-ideal-btb-0.3c.yml(1 hunks)README.md(1 hunks)
🔇 Additional comments (2)
.github/workflows/gem5-ideal-btb-0.3c.yml (1)
15-20: Workflow structure looks good.The use of a reusable workflow template with explicit inputs (
script_pathandbenchmark_type) is a clean, maintainable pattern. The trigger conditions are well-documented with the inline comment (line 5).README.md (1)
49-61: Documentation for Kunminghu configuration variants is accurate and complete.The "Kunminghu configuration variants and CI coverage" section (lines 49–61) is well-organized and all referenced CI workflows exist in the codebase with matching names:
- Line 53: "gem5 Performance Test (Tier 2 - Post-Merge)" is defined in
.github/workflows/gem5-perf.yml✓- Line 54: "gem5 Align BTB Performance Test(0.3c)" is defined in
.github/workflows/gem5-ideal-btb-0.3c.yml✓- Line 55: "gem5 Ideal BTB Performance Test" is defined in
.github/workflows/gem5-ideal-btb-perf.yml✓The branch naming convention (*-align, *-perf) and score comparability caveats are properly documented.
Change-Id: If6f28d0ac57d57e07b716241136d106217123c72
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.