Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
🚧 Files skipped from review as they are similar to previous changes (7)
📝 WalkthroughWalkthroughCI workflow configurations updated to use compiler-prefixed SPEC benchmark names: Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e065844f-6bce-46d8-b29a-4ca6ec4db8e8
📒 Files selected for processing (9)
.github/workflows/README.md.github/workflows/gem5-ideal-btb-0.3c.yml.github/workflows/gem5-ideal-btb-perf-weekly.yml.github/workflows/gem5-ideal-btb-perf.yml.github/workflows/gem5-perf-template.yml.github/workflows/gem5-perf.yml.github/workflows/manual-perf.yml.github/workflows/on-demand-spec.ymlREADME.md
🚀 Coremark Smoke Test Results
✅ Difftest smoke test passed! |
- gem5-perf-template.yml: renamed SPEC06 baseline benchmark keys from spec06-{0.3c,0.8c,1.0c} to gcc12-spec06-{0.3c,0.8c,1.0c}; added gcc15-spec06-{0.3c,0.8c,1.0c} mappings with dedicated checkpoint_list/checkpoint_root_node/score_script/cluster_config/artifact_name/comment outputs; updated benchmark_type input description and Invalid benchmark_type error list to the new full option set.
- gem5-perf.yml: updated benchmark_type from spec06-0.8c to gcc12-spec06-0.8c.
- gem5-ideal-btb-perf.yml: updated benchmark_type from spec06-0.8c to gcc12-spec06-0.8c.
- gem5-ideal-btb-0.3c.yml: updated benchmark_type from spec06-0.3c to gcc12-spec06-0.3c.
- gem5-ideal-btb-perf-weekly.yml: switched both SPEC06 jobs to gcc15-spec06-1.0c; kept SPEC17 jobs unchanged.
- manual-perf.yml: changed benchmark_type default to gcc12-spec06-0.8c; replaced SPEC06 options with explicit gcc12/gcc15 variants (gcc12-spec06-{0.3c,0.8c,1.0c} and gcc15-spec06-{0.3c,0.8c,1.0c}); kept spec17/rvv options.
- on-demand-spec.yml: migrated on-demand SPEC06 naming to gcc12-only scope (default/options/label-trigger default/comment text), without adding gcc15 options.
Change-Id: Ie086b2fca06178f9dc47338da93a3af6f0f7327e
jensen-yan
approved these changes
Mar 12, 2026
Collaborator
|
不确定，要不要把默认的0.3c， 0.8c 的自动切换到gcc15 上，如果这次不切换，那就下周切换一下 |
🚀 Coremark Smoke Test Results
✅ Difftest smoke test passed! |
Contributor
Author
ok的，另外就是-perf默认触发还是gcc12 0.8的，这周组会再确认下，后续一起再切换吧 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gem5-perf-template.yml: renamed SPEC06 baseline benchmark keys from spec06-{0.3c,0.8c,1.0c} to gcc12-spec06-{0.3c,0.8c,1.0c}; added gcc15-spec06-{0.3c,0.8c,1.0c} mappings with dedicated checkpoint_list/checkpoint_root_node/score_script/cluster_config/artifact_name/comment outputs; updated benchmark_type input description and Invalid benchmark_type error list to the new full option set.
gem5-perf.yml: updated benchmark_type from spec06-0.8c to gcc12-spec06-0.8c.
gem5-ideal-btb-perf.yml: updated benchmark_type from spec06-0.8c to gcc12-spec06-0.8c.
gem5-ideal-btb-0.3c.yml: updated benchmark_type from spec06-0.3c to gcc12-spec06-0.3c.
gem5-ideal-btb-perf-weekly.yml: switched both SPEC06 jobs to gcc15-spec06-1.0c; kept SPEC17 jobs unchanged.
manual-perf.yml: changed benchmark_type default to gcc12-spec06-0.8c; replaced SPEC06 options with explicit gcc12/gcc15 variants (gcc12-spec06-{0.3c,0.8c,1.0c} and gcc15-spec06-{0.3c,0.8c,1.0c}); kept spec17/rvv options.
on-demand-spec.yml: migrated on-demand SPEC06 naming to gcc12-only scope (default/options/label-trigger default/comment text), without adding gcc15 options.
Change-Id: Ie086b2fca06178f9dc47338da93a3af6f0f7327e
Summary by CodeRabbit
Chores
Documentation