Skip to content

util: add weekly CI kmhv3.py configs for spec06 and spec17#669

Merged
jensen-yan merged 1 commit intoxs-devfrom
add-alignTest-ci
Dec 25, 2025
Merged

util: add weekly CI kmhv3.py configs for spec06 and spec17#669
jensen-yan merged 1 commit intoxs-devfrom
add-alignTest-ci

Conversation

@jensen-yan
Copy link
Copy Markdown
Collaborator

@jensen-yan jensen-yan commented Dec 23, 2025

The previous vector test job has been commented out for future reference.

Change-Id: I8317f5c155e25eb653fe7897ee980bc58a5246d0

Summary by CodeRabbit

  • Chores
    • Added new performance benchmark test configurations to the automated testing pipeline.
    • Deprecated a previous vector-based performance test configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

The previous vector test job has been commented out for future reference.

Change-Id: I8317f5c155e25eb653fe7897ee980bc58a5246d0
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 23, 2025

Walkthrough

Added two new workflow jobs (align_test_spec06 and align_test_spec17) to the gem5-ideal-btb-perf-weekly workflow that reuse the gem5-perf-template with the kmh_v3_btb script and respective benchmark types. The previous perf_test_spec06_vector job was commented out and deprecated.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Update
.github/workflows/gem5-ideal-btb-perf-weekly.yml
Added two new performance test jobs (align_test_spec06, align_test_spec17) reusing gem5-perf-template with script_path set to ../kmh_v3_btb.sh and benchmark types spec06-1.0c and spec17-1.0c respectively. Deprecated perf_test_spec06_vector job by commenting out its configuration block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • util: update README and rename CI configs[skip ci] #647: Adds Align BTB performance test jobs to GitHub workflow configuration with similar reuse of gem5-perf-template and kmh_v3_btb script.
  • Add kmhv3 #609: Modifies the same gem5-ideal-btb-perf-weekly workflow file to update performance job definitions and script paths.
  • Fix ci sha #616: Updates gem5-perf-template inputs handling, which is the template reused by the new workflow jobs.

Suggested labels

perf

Suggested reviewers

  • tastynoob
  • Yakkhini
  • CJ362ff

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding weekly CI kmhv3.py configs for SPEC06 and SPEC17 benchmarks to the workflow file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-alignTest-ci

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ef695e and f3be74c.

📒 Files selected for processing (1)
  • .github/workflows/gem5-ideal-btb-perf-weekly.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Quick Build, Unit Tests & Smoke Test
🔇 Additional comments (2)
.github/workflows/gem5-ideal-btb-perf-weekly.yml (2)

35-41: Commented code preserved for future reference.

The vector test job has been properly commented out, which aligns with the PR objectives. This approach preserves the configuration for potential future use.


11-22: LGTM! Job additions follow the established pattern.

The new align_test jobs are properly structured, use the correct script paths, and follow the same pattern as existing perf_test jobs. Both the referenced script (kmh_v3_btb.sh) and template workflow exist and are correctly configured.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

🚀 Coremark Smoke Test Results

Branch IPC Change
Base (xs-dev) 2.0659 -
This PR 2.0659 ➡️ 0.0000 (0.00%)

✅ Difftest smoke test passed!

@jensen-yan jensen-yan merged commit 6ae4d0e into xs-dev Dec 25, 2025
2 checks passed
@jensen-yan jensen-yan deleted the add-alignTest-ci branch December 25, 2025 03:29
This was referenced Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants