feat: add contains ignore case in go to row#1291
Merged
ethanalvizo merged 4 commits intodeephaven:mainfrom May 17, 2023
Merged
Conversation
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
mofojed
reviewed
May 11, 2023
ethanalvizo
force-pushed
the
1274-new-seek-row-option
branch
from
33af2df to
2ba0f6c
Compare
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
ethanalvizo
force-pushed
the
1274-new-seek-row-option
branch
from
2ba0f6c to
4baa67e
Compare
Codecov Report
@@ Coverage Diff @@
## main #1291 +/- ##
==========================================
- Coverage 45.89% 45.54% -0.35%
==========================================
Files 492 504 +12
Lines 34371 34827 +456
Branches 8566 8690 +124
==========================================
+ Hits 15775 15863 +88
- Misses 18545 18913 +368
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mofojed
previously approved these changes
May 12, 2023
ethanalvizo
force-pushed
the
1274-new-seek-row-option
branch
from
4baa67e to
6635d6e
Compare
mofojed
requested changes
May 12, 2023
ethanalvizo
force-pushed
the
1274-new-seek-row-option
branch
from
6635d6e to
90227c1
Compare
mofojed
requested changes
May 12, 2023
ethanalvizo
force-pushed
the
1274-new-seek-row-option
branch
from
edd980e to
c3ad3f1
Compare
ethanalvizo
force-pushed
the
1274-new-seek-row-option
branch
from
c3ad3f1 to
d4c2ad9
Compare
mofojed
requested changes
May 15, 2023
mofojed
approved these changes
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1274