fix: Cherry-pick DH-17599: Fix table name validation (#2403)#2404
Merged
vbabich merged 1 commit intodeephaven:release/v0.85from Apr 9, 2025
Merged
Conversation
PR deephaven#2398 allowed hyphens in namespace and table names. However, I noticed that server-side validation rejects names starting with a hyphen, while these names appear valid on the client-side. `io.deephaven.db.tables.utils.DBNameValidator` uses separate regular expressions to sanitize and validate names. This change adds the correct `TABLE_NAME_PATTERN` for table name validation instead of checking if the name matches its sanitized version. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vbabich
requested review from
a team and
bmingles
and removed request for
a team
bmingles
reviewed
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2398 allowed hyphens in namespace and table names. However, I
noticed that server-side validation rejects names starting with a
hyphen, while these names appear valid on the client-side.
io.deephaven.db.tables.utils.DBNameValidatoruses separate regularexpressions to sanitize and validate names. This change adds the correct
TABLE_NAME_PATTERNfor table name validation instead of checking ifthe name matches its sanitized version.
Co-authored-by: Copilot 175728472+Copilot@users.noreply.github.com