[devtools] Fix "View source" for sources with URLs that aren't normalized#32951
Merged
eps1lon merged 3 commits intofacebook:mainfrom Apr 17, 2025
Merged
Conversation
github-actions
Bot
added
the
React Core Team
hoxyq
approved these changes
Apr 17, 2025
eps1lon
commented
Apr 17, 2025
hoxyq
approved these changes
Apr 17, 2025
eps1lon
force-pushed
the
sebbie/rdt-open-source-normalized
branch
from
f5307e2 to
d7ad0d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chrome lists resources with their normalized URLs. However, sourcemaps may contain unnormalized URLs in their
sources. When symbolicating we get the original entry insourcesnot the normalized URL so we need to consider that when callingopenResource. Otherwise nothing happens and you only see an error when you actually inspect React DevTools e.g.extensions.js:1 Extension server error: Object not found: webpack-internal:///(app-pages-browser)/./app/page.tsxHow did you test this change?
Use a local build (
yarn build:chrome:local) in a basic Next.js app with Webpack and click "View source" for the root page.Firefox has "View source" disabled for me even with the published version.