Skip to content

Biohackathon fixes#2695

Merged
nsoranzo merged 28 commits into
galaxyproject:masterfrom
mvdbeek:biohackathon_fixes
Nov 28, 2019
Merged

Biohackathon fixes#2695
nsoranzo merged 28 commits into
galaxyproject:masterfrom
mvdbeek:biohackathon_fixes

Conversation

@mvdbeek
Copy link
Copy Markdown
Member

@mvdbeek mvdbeek commented Nov 27, 2019

This PR collects all fixes done so far during the biohackathon and in preparation to test all tools on this repo.

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@mvdbeek mvdbeek requested a review from shiltemann as a code owner November 27, 2019 10:40
Comment thread tools/obitools/macros.xml Outdated
Comment thread data_managers/data_manager_rsync_g2/data_manager/data_manager_rsync.py Outdated
@nsoranzo
Copy link
Copy Markdown
Member

Not sure why kobas_annotate test does not produce output for 20', ping @blankclemens .

@mvdbeek
Copy link
Copy Markdown
Member Author

mvdbeek commented Nov 27, 2019

It does eventually produce output when using github workflows, though it fails because of missing libbz2:
Screenshot 2019-11-27 at 17 16 00

@mvdbeek
Copy link
Copy Markdown
Member Author

mvdbeek commented Nov 27, 2019

Anyway, probably better to do smaller PRs here to not get slowed down

@nsoranzo
Copy link
Copy Markdown
Member

I've replicated the kobas_annotate issue on my laptop, it's stuck trying to create the conda environment:

conda create -y --quiet --override-channels --channel iuc --channel conda-forge --channel bioconda --channel defaults --name __kobas@2.1.1 kobas=2.1.1

After more than 20' it still hasn't solved the environment.

@bgruening
Copy link
Copy Markdown
Member

@nsoranzo can we bump the conda recipe and get a new build?

@mvdbeek
Copy link
Copy Markdown
Member Author

mvdbeek commented Nov 28, 2019

Yeah, it's been doing that all night on my laptop (I just added bzip2). The 2.1.1 recipe is not in the branch anymore, should we add that back ?

@nsoranzo
Copy link
Copy Markdown
Member

@mvdbeek I'm going to push a fix in a bit, adding r-base 3.4 as additional requirement for kobas tools.

@mvdbeek
Copy link
Copy Markdown
Member Author

mvdbeek commented Nov 28, 2019

Cool! If you want you could rebase out the mothur changes so that we actually get a chance at getting the tool tests to finish on time.

@nsoranzo nsoranzo mentioned this pull request Nov 28, 2019
5 tasks
mvdbeek and others added 10 commits November 28, 2019 17:46
The test comes from a time when we didn't test data managers yet,
so I think this probably didn't work. fwiw the output looks correct:
```
{"data_tables": {"all_fasta": [{"dbkey": "refseq_plastid.97.protein", "name": "RefSeq plastid Release 97 protein (2018-03-14)", "path": "/tmp/tmp_uJxfm/job_working_directory/000/1/dataset_8405ba59-24ae-4600-b132-38b696e22e49_files/plastid.97.protein.fasta", "value": "refseq_plastid.97.protein"}]}}
```
Co-Authored-By: Nicola Soranzo <nicola.soranzo@gmail.com>
@nsoranzo
Copy link
Copy Markdown
Member

Cool! If you want you could rebase out the mothur changes so that we actually get a chance at getting the tool tests to finish on time.

Done!

@nsoranzo nsoranzo merged commit 57f71aa into galaxyproject:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants