Change bridge_name to name and bridge_params to parameters#673
Conversation
The "bridge_" in these attributes seems redundant. This patch removes the prefix and aligns the names with the attribute names of `Node` (`<node>`). Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
If I remember correctly, it was to differentiate between |
|
I see. I think it makes sense to have |
🦟 Bug fix
Summary
I'm proposing that we change the attribute names because "bridge_" in the attributes seems redundant. The change I propose also alignes the attributes with the attribute names of
Node(<node>), which arenameandparameters.Example:
Before:
After:
#600 changed
nametobridge_name, but I'm not sure why that was necessary. @Amronos?Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.