Conversation
qqmyers
left a comment
qqmyers
left a comment
There was a problem hiding this comment.
Cool! I made a few comments, none are critical, so unless you want to make changes for any of them, I'll go ahead and merge and we can deal with future changes (from whoever) as separate PRs. Just let me know when it's OK to merge.
Re: packages - I like the idea of keeping things together, but the scripts can nominally be used on different fields/several fields so it's not clear that packages is a good general way to organize. In any case, we don't have anything better for now, so, again, I can merge and think about this later.
- reduced delay to fetch from LC API to 500ms - cleaned solution to catch lc frame being added multiple times - small formatting things
Ok, on our side this will be earliest be added in September. Anyway, if later, once there is a final location, I just need to know where it sits, so they can update their lc-cvoc-conf.json. |
I'll try to remember to ping you in any PR for that. FWIW - in #22 updates to the README, I recommend that people deploy the scripts locally for production (perhaps creating a fork would work too). We do serve the dataverse-previewers from github.io, but trying to assure we never make changes that can affect someone's production instance is a pain and we now have several versions served in parallel since we don't know who may still be using the older ones. |
|
Now I see again, why I had "allow-free-text": true, before. If it is set to false, I am not able to set that value, via the dv API |
2 participants
As discussed with @qqmyers this pull request contains all files for local contexts cvoc