Improvements to ORCID and ROR support#22
Merged
Conversation
FWIW: Sort needs to handle 3 cases - one or the other of the entries has the condition, or both do/don't. Using Number converts true/false to 1/0 and substracting the test on a from the one on b gives the right 3 values.
support managed fields use util methods for storing local data fix error/plain text handling fix behavior with 0 lookup results fix prioritization of locally stored vals change display to match family, given in author field change separator to ;
This was referenced Jul 21, 2024
Closed
landreev
reviewed
Sep 25, 2024
Member
Author
|
With IQSS/dataverse#10712 merged, I'll go ahead and merge this so we're 6.4 ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple changes to support parent/managed fields, fixes/improvements. The parent/managed field changes work with changes being submitted for Dataverse 6.4. The other bug fixes/improvements should be backward compatible.
Planning to add some documentation/perhaps rearrange scripts/examples to make it clearer which ones are potentially production usable versus one-off demos. Will link DV PR(s) when those are ready. Also will add :CVocConf setting.