Fix TerraformProvider alias definition

[jsteinich]

Match override behavior of generated provider schema

I'm not sure yet how this passed tests in #276, but this should fix the integration tests.

It is quite strange to me that terraform provider schema include alias when it is really more of a meta argument. If anyone from the terraform team could provide more context, that could make me more confident that this is the correct approach.

[skorfmann]

I'm not sure yet how this passed tests in #276, but this should fix the integration tests.

Yeah, a bit strange. I think I had a similar issue a while ago.

It is quite strange to me that terraform provider schema include alias when it is really more of a meta argument. If anyone from the terraform team could provide more context, that could make me more confident that this is the correct approach.

Yes, that's a bit weird - See #44

[skorfmann]

👍

[jsteinich]

@skorfmann thanks for that link. After reading that I have a strong suspicion as to the cause that we'll need to follow up on.

The release workflow only builds on Terraform 12 so it will have providers with alias.
The PR workflow builds both and uploads the same name/path artifacts. I'm guessing the 13 artifacts (without alias) generally take slightly longer to build so end up being what's used by integration tests.

I didn't think I had 13 installed locally so I'm not quite sure why I didn't see this locally before, but I'll double check.

[skorfmann]

@skorfmann thanks for that link. After reading that I have a strong suspicion as to the cause that we'll need to follow up on.

Here's the follow up #333

The release workflow only builds on Terraform 12 so it will have providers with alias.

There's a quick'n dirty workaround to address this #44

The PR workflow builds both and uploads the same name/path artifacts. I'm guessing the 13 artifacts (without alias) generally take slightly longer to build so end up being what's used by integration tests.

I don't think the package builds are depending on the Terraform version. However, it'd still be nice if the behaviour was more predictable.

I didn't think I had 13 installed locally so I'm not quite sure why I didn't see this locally before, but I'll double check.

As said above, I doubt that it's depending on the Terraform version

[jsteinich]

There's a quick'n dirty workaround to address this #44

Somehow I missed that line when looking at that function. That makes me feel a lot better about this patch.

I don't think the package builds are depending on the Terraform version. However, it'd still be nice if the behaviour was more predictable.

I'm pretty sure you're correct. I guess that was just wishful thinking and not being awake enough yet. I'll make a follow up issue for that.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.