Skip to content

Pull request for release of 2.1.0#363

Merged
apeltzer merged 689 commits intomasterfrom
dev
Mar 5, 2020
Merged

Pull request for release of 2.1.0#363
apeltzer merged 689 commits intomasterfrom
dev

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Mar 2, 2020

This PR is for the nf-core/eager release 2.1.0 (Ravensburg).

Please see the CHANGELOG.md for a complete list of changes.

This release includes extensive changes to the channel logical, allowing a user to turn on/off modules (i.e. skipping processes).

This release makes nf-core/eager reach essentially functional parity with EAGER 1 with:

  • Genotyping: GATK HaplotypeCaller, GATK UnifiedGenotyper (and bonus addition of FeeBayes)
  • Endogenous DNA calculation: endorS.py
  • Mitochondrial to Nuclear Ratio: MT2NucRatio

It also includes additional functionality, specifically in allowing automated metagenomic screening typically used in ancient pathogen and microbiome work

  • Taxonomic binning: MALT, Kraken
  • High-throughput aDNA screening: MaltExtract
  • SNP Table generation: MultiVCFAnalyzer
  • Feature statistics (e.g. gene depth/breadth): bedtools

Additional functionality:

  • Human nuclear contamination estimation
  • Human sex determination

Finally, it comes with a extensive usage and output documentation with useful schematic diagrams and a great new logo.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

jfy133 and others added 30 commits December 3, 2019 17:46
Co-Authored-By: Alexander Peltzer <apeltzer@users.noreply.github.com>
Allows supplying FAI/Dict and still run genotyping
Also add a small travis fix

Co-Authored-By: Alexander Peltzer <apeltzer@users.noreply.github.com>
@jfy133 jfy133 added the 2.1.0 label Mar 2, 2020
@jfy133 jfy133 requested a review from a team March 2, 2020 11:19
@maxibor maxibor linked an issue Mar 3, 2020 that may be closed by this pull request
Copy link
Copy Markdown
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find anything, but I reviewed this like 10x already in all the individual steps :-/

Copy link
Copy Markdown
Member

@maxibor maxibor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished review. Overall, my main suggestion is to remove the hardcoded default values in the help menu of eager, and replace them with ${params.parameter}.
This is because the defaults might change depending on the configuration file used.

Comment thread .github/ISSUE_TEMPLATE/bug_report.md Outdated
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread Dockerfile
Comment thread README.md Outdated
Comment thread main.nf Outdated
Comment thread main.nf Outdated
Comment thread main.nf Outdated
Comment thread main.nf Outdated
Comment thread main.nf Outdated
@maxibor maxibor added this to the V2.1 "Ravensburg" milestone Mar 5, 2020
@jfy133 jfy133 requested a review from maxibor March 5, 2020 14:18
@apeltzer apeltzer merged commit 26ae7e9 into master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants