Skip to content

Add paraphrase#10273

Merged
fellen31 merged 5 commits intonf-core:masterfrom
fellen31:add-paraphrase
Feb 27, 2026
Merged

Add paraphrase#10273
fellen31 merged 5 commits intonf-core:masterfrom
fellen31:add-paraphrase

Conversation

@fellen31
Copy link
Copy Markdown
Contributor

@fellen31 fellen31 commented Feb 26, 2026

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Copy Markdown
Contributor

@Joon-Klaps Joon-Klaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions.

  • use sanitizeOuput
  • Include stub snapshot

Comment thread modules/nf-core/paraphrase/tests/main.nf.test Outdated
Comment thread modules/nf-core/paraphrase/tests/main.nf.test Outdated
Comment thread modules/nf-core/paraphrase/tests/main.nf.test Outdated
Comment thread modules/nf-core/paraphrase/tests/main.nf.test Outdated
Comment thread modules/nf-core/paraphrase/tests/main.nf.test
fellen31 and others added 2 commits February 27, 2026 13:26
Co-authored-by: Joon Klaps <joon.klaps@kuleuven.be>
@fellen31 fellen31 requested review from a team as code owners February 27, 2026 12:43
@fellen31 fellen31 removed request for a team February 27, 2026 12:45
@fellen31 fellen31 requested a review from Joon-Klaps February 27, 2026 13:19
Copy link
Copy Markdown
Contributor

@Joon-Klaps Joon-Klaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fellen31 fellen31 added this pull request to the merge queue Feb 27, 2026
Merged via the queue into nf-core:master with commit f3e0289 Feb 27, 2026
34 checks passed
@fellen31 fellen31 deleted the add-paraphrase branch February 27, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants