Add cabinet maker to craft.json (needs to be redone)#1980
Closed
matkoniecz wants to merge 1 commit intomainfrom
Closed
Add cabinet maker to craft.json (needs to be redone)#1980matkoniecz wants to merge 1 commit intomainfrom
matkoniecz wants to merge 1 commit intomainfrom
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
Collaborator
Author
matkoniecz
added a commit
to matkoniecz/id-tagging-schema
that referenced
this pull request
Mar 5, 2026
closes openstreetmap#995 which added also many low use ones, see openstreetmap#1573 for precedent. replaced openstreetmap#1980
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I like
"cabinet_maker": "Cabinet Maker Workshop",or similar that would be more clear that it is not for their office (if separate from workshop), but I added in style matching existing onesDescription, Motivation & Context
Related issues
closes #995 which added also many low use ones, see #1573 for precedent.
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.