Skip to content

Add cabinet maker to craft.json (needs to be redone)#1980

Closed
matkoniecz wants to merge 1 commit intomainfrom
matkoniecz-patch-11
Closed

Add cabinet maker to craft.json (needs to be redone)#1980
matkoniecz wants to merge 1 commit intomainfrom
matkoniecz-patch-11

Conversation

@matkoniecz
Copy link
Copy Markdown
Collaborator

I like "cabinet_maker": "Cabinet Maker Workshop", or similar that would be more clear that it is not for their office (if separate from workshop), but I added in style matching existing ones

Description, Motivation & Context

Related issues

closes #995 which added also many low use ones, see #1573 for precedent.

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

I like `"cabinet_maker": "Cabinet Maker Workshop",` or similar that would be more clear that it is not for their office (if separate from workshop), but I added in style matching existing ones

closes #995 which added also many low use ones, see #1573 for precedent.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2026

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

screen-2026-03-04-03-56-14

wait, this should be dedicated POI type

@matkoniecz matkoniecz changed the title Add cabinet maker to craft.json Add cabinet maker to craft.json (needs to be redone) Mar 4, 2026
@matkoniecz
Copy link
Copy Markdown
Collaborator Author

@matkoniecz matkoniecz closed this Mar 5, 2026
matkoniecz added a commit to matkoniecz/id-tagging-schema that referenced this pull request Mar 5, 2026
closes openstreetmap#995 which added also many low use ones, see openstreetmap#1573 for precedent.

replaced openstreetmap#1980
@matkoniecz matkoniecz mentioned this pull request Mar 5, 2026
@matkoniecz matkoniecz deleted the matkoniecz-patch-11 branch March 20, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant