Add cuisine=syrian support [should it wait for 500 uses?]#1573
Add cuisine=syrian support [should it wait for 500 uses?]#1573matkoniecz wants to merge 1 commit intoopenstreetmap:mainfrom
cuisine=syrian support [should it wait for 500 uses?]#1573Conversation
|
@simonpoole - do you think that such tags also should go through community discussion? |
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
|
No particular opinion. In general non-conflicting/non-overlapping values are unproblematic, iD is probably already offering this as is. Really the only question is there actually a distinctive Syrian cuisine or not. |
I guess that question like this can be controversial in extreme cases, but here it should be fine (I know about multiple food places self-describing themselves as serving Syrian cuisine) |
|
if dedicated feature entry is supposed to be added there, then something like https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/amenity/restaurant/georgian.json should be added not sure is it really needed |
|
In general, this looks good. However, …
Others can weight in, if course, but I would say lets wait for a bit more organic usage first. |
cuisine=syrian support
cuisine=syrian supportcuisine=syrian support [should it wait for 500 uses?]
noone did, it will take long time to reach 500 - so maybe better close it? BTW, #1641 found some cuisines with 500+ uses not supported yet. |
threshold based on openstreetmap#1573
closes openstreetmap#995 which added also many low use ones, see openstreetmap#1573 for precedent. replaced openstreetmap#1980



Description, Motivation & Context
add cuisine=syrian support
Related issues
Links and data
Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Tag:cuisine%3Dsyrian (disclaimer: I just created it)
Relevant tag usage stats:
290 uses, see https://taginfo.openstreetmap.org/tags/cuisine=syrian#overview
matches other cuisine tagging
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.