Skip to content

Add cuisine=syrian support [should it wait for 500 uses?]#1573

Closed
matkoniecz wants to merge 1 commit intoopenstreetmap:mainfrom
matkoniecz:syrian
Closed

Add cuisine=syrian support [should it wait for 500 uses?]#1573
matkoniecz wants to merge 1 commit intoopenstreetmap:mainfrom
matkoniecz:syrian

Conversation

@matkoniecz
Copy link
Copy Markdown
Collaborator

Description, Motivation & Context

add cuisine=syrian support

Related issues

Links and data

Relevant OSM Wiki links:

https://wiki.openstreetmap.org/wiki/Tag:cuisine%3Dsyrian (disclaimer: I just created it)

Relevant tag usage stats:

290 uses, see https://taginfo.openstreetmap.org/tags/cuisine=syrian#overview

matches other cuisine tagging

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

@simonpoole - do you think that such tags also should go through community discussion?

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@simonpoole
Copy link
Copy Markdown
Contributor

No particular opinion. In general non-conflicting/non-overlapping values are unproblematic, iD is probably already offering this as is.

Really the only question is there actually a distinctive Syrian cuisine or not.

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

Really the only question is there actually a distinctive Syrian cuisine or not.

I guess that question like this can be controversial in extreme cases, but here it should be fine (I know about multiple food places self-describing themselves as serving Syrian cuisine)

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

Test-Documentation

Preview links & Sidebar Screenshots

Search

screen-2025-05-27-14-07-35

Not found in general search. Maybe it should be?

screen-2025-05-27-14-08-00

Info-i

screen-2025-05-27-14-08-40

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

@matkoniecz matkoniecz changed the title add cuisine=syrian support add cuisine=syrian support [Test documentation done] May 27, 2025
@matkoniecz
Copy link
Copy Markdown
Collaborator Author

if dedicated feature entry is supposed to be added there, then something like https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/amenity/restaurant/georgian.json should be added

not sure is it really needed

This was referenced May 28, 2025
@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Jun 3, 2025

In general, this looks good. However, …

Others can weight in, if course, but I would say lets wait for a bit more organic usage first.

@tordans tordans added field wontfix-niche This tag is (yet) used too rarely to be considered for a preset. labels Jun 3, 2025
@tordans tordans changed the title add cuisine=syrian support [Test documentation done] Add cuisine=syrian support Jun 3, 2025
@tordans tordans added waitfor-higher-usage this may look good but lets wait for higher usage number for the tags. and removed wontfix-niche This tag is (yet) used too rarely to be considered for a preset. labels Jun 3, 2025
@matkoniecz matkoniecz changed the title Add cuisine=syrian support Add cuisine=syrian support [should it wait for 500 uses?] Jun 3, 2025
@matkoniecz
Copy link
Copy Markdown
Collaborator Author

Others can weight in, if course, but I would say lets wait for a bit more organic usage first.

noone did, it will take long time to reach 500 - so maybe better close it?

BTW, #1641 found some cuisines with 500+ uses not supported yet.

@matkoniecz matkoniecz closed this Jul 27, 2025
matkoniecz added a commit to matkoniecz/id-tagging-schema that referenced this pull request Feb 23, 2026
matkoniecz added a commit that referenced this pull request Mar 4, 2026
I like `"cabinet_maker": "Cabinet Maker Workshop",` or similar that would be more clear that it is not for their office (if separate from workshop), but I added in style matching existing ones

closes #995 which added also many low use ones, see #1573 for precedent.
matkoniecz added a commit to matkoniecz/id-tagging-schema that referenced this pull request Mar 5, 2026
closes openstreetmap#995 which added also many low use ones, see openstreetmap#1573 for precedent.

replaced openstreetmap#1980
@matkoniecz matkoniecz mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

field waitfor-higher-usage this may look good but lets wait for higher usage number for the tags.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants