Skip to content

Add more translatable strings for craft values#995

Closed
kjonosm wants to merge 4 commits intoopenstreetmap:mainfrom
kjonosm:patch-38
Closed

Add more translatable strings for craft values#995
kjonosm wants to merge 4 commits intoopenstreetmap:mainfrom
kjonosm:patch-38

Conversation

@kjonosm
Copy link
Copy Markdown
Contributor

@kjonosm kjonosm commented Sep 5, 2023

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 5, 2023

🍱 Preview the tagging presets of this pull request here: https://pr-995--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

Comment thread data/fields/craft.json Outdated
Comment thread data/fields/craft.json Outdated
@tordans tordans added the field label Sep 8, 2025
@tordans tordans changed the title Add more translatable strings to craft.json Add more translatable strings for craft values Sep 8, 2025
Comment thread data/fields/craft.json Outdated
@matkoniecz
Copy link
Copy Markdown
Collaborator

matkoniecz commented Jan 13, 2026

I propose to close it in 90 days if no activity happens here that would lead toward fixing )or explaining why it is fine as is)

Comment thread data/fields/craft.json
"tailor": "Tailor",
"tiler": "Tiler",
"tinsmith": "Tinsmith",
"toolmaker": "Toolmaker",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread data/fields/craft.json
"sculptor": "Sculptor",
"shoemaker": "Shoemaker",
"signmaker": "Signmaker",
"stand_builder": "Booth Builder",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread data/fields/craft.json
"oil_mill": "Oil Mill",
"painter": "Painter",
"parquet_layer": "Parquet Layer",
"pest_control": "Pest Exterminator",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread data/fields/craft.json
"builder": "Builder",
"gardener": "Gardener",
"glaziery": "Glaziery",
"goldsmith": "Goldsmith",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread data/fields/craft.json
"bookbinder": "Bookbinder",
"brewery": "Brewery",
"builder": "Builder",
"cabinet_maker": "Cabinet Maker",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matkoniecz
Copy link
Copy Markdown
Collaborator

matkoniecz commented Feb 27, 2026

@tordans You protested in past against including tags appearing less than 500 times - do you still think it would be a bad idea to support such low-use tags?

I guess there were also protests on ground of iD pushing specific low use tagging.

(if someone feels that #1573 decision should be revised, feel free to create a new issue to discuss it)

Also, craft=pest_control would be probably best to be introduced with its shop= variant.

@matkoniecz
Copy link
Copy Markdown
Collaborator

So I would say: from this pool cabinet_maker is eligible, per #1573 precedent.

@matkoniecz
Copy link
Copy Markdown
Collaborator

matkoniecz commented Feb 27, 2026

@1ec5 Is "Cabinet maker" or "Cabinetmaker" preferred US form? I am getting mixed info from research so far, except that claim that both are US English and understandable.

matkoniecz added a commit that referenced this pull request Mar 4, 2026
I like `"cabinet_maker": "Cabinet Maker Workshop",` or similar that would be more clear that it is not for their office (if separate from workshop), but I added in style matching existing ones

closes #995 which added also many low use ones, see #1573 for precedent.
matkoniecz added a commit to matkoniecz/id-tagging-schema that referenced this pull request Mar 5, 2026
closes openstreetmap#995 which added also many low use ones, see openstreetmap#1573 for precedent.

replaced openstreetmap#1980
@matkoniecz matkoniecz mentioned this pull request Mar 5, 2026
@matkoniecz
Copy link
Copy Markdown
Collaborator

@matkoniecz
Copy link
Copy Markdown
Collaborator

closing per #995 (comment)

(if someone feels that #1573 decision should be revised, feel free to create a new issue to discuss it)

@matkoniecz matkoniecz closed this Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants