Re-submit cuttlefish tls schema for amqp_client#15767
Merged
michaelklishin merged 1 commit intorabbitmq:mainfrom Mar 18, 2026
Merged
Re-submit cuttlefish tls schema for amqp_client#15767michaelklishin merged 1 commit intorabbitmq:mainfrom
amqp_client#15767michaelklishin merged 1 commit intorabbitmq:mainfrom
Conversation
lukebakken
force-pushed
the
amqp_client_schema-gh-11415-followup
branch
from
db2c95d to
e97be87
Compare
lukebakken
force-pushed
the
amqp_client_schema-gh-11415-followup
branch
from
e97be87 to
bbb6497
Compare
Collaborator
|
Thank you, @lukebakken. Re-submitted with some follow-up changes from me #15772. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up PR to the following:
Having cuttlefish schemas for
amqp_clientandamqp10_clientstill seems useful, so I looked into why this was reverted. Since bazel is no longer used, that reason no longer exists. In my local env, all of these test runs succeed just fine: