Skip to content

Improve TLS-related rabbitmq.conf settings of amqp_client (backport #15772) (backport #15773)#15774

Merged
michaelklishin merged 2 commits intov4.2.xfrom
mergify/bp/v4.2.x/pr-15773
Mar 19, 2026
Merged

Improve TLS-related rabbitmq.conf settings of amqp_client (backport #15772) (backport #15773)#15774
michaelklishin merged 2 commits intov4.2.xfrom
mergify/bp/v4.2.x/pr-15773

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Mar 18, 2026

This is #15767 by @lukebakken with some tweaks from me:

  1. A few places quietly returned undefined instead of using cuttlefish:unset/0
  2. The SNI key used cuttlefish:unset/0 where it should have used disable when the value is set to none in rabbitmq.conf (the current behavior ends up deriving the SNI from the local hostname (a dubious behavior in the Erlang/OTP's ssl or inet apps if you ask me)
  3. Added a bunch of config_schema_SUITE test cases for less commonly used TLS-related keys

References

  1. cuttlefish tls schema for amqp_client #11415
  2. Revert "cuttlefish tls schema for amqp_client" #11531
  3. Re-submit cuttlefish tls schema for amqp_client #15767
    This is an automatic backport of pull request Improve TLS-related rabbitmq.conf settings of amqp_client #15772 done by Mergify.
    This is an automatic backport of pull request Improve TLS-related rabbitmq.conf settings of amqp_client (backport #15772) #15773 done by Mergify.

lukebakken and others added 2 commits March 18, 2026 23:28
…ent_schema"

This reverts commit 4b4c0fe, reversing
changes made to b9bbf69.

(cherry picked from commit bbb6497)
(cherry picked from commit 86f9b18)
A follow-up to #15767.

(cherry picked from commit 5c0d7f5)
(cherry picked from commit 22df658)
@michaelklishin michaelklishin added this to the 4.2.6 milestone Mar 18, 2026
@michaelklishin michaelklishin merged commit 62edf4f into v4.2.x Mar 19, 2026
576 of 585 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v4.2.x/pr-15773 branch March 19, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants