Skip to content

Improve TLS-related rabbitmq.conf settings of amqp_client (backport #15772)#15773

Merged
michaelklishin merged 2 commits intov4.3.xfrom
mergify/bp/v4.3.x/pr-15772
Mar 18, 2026
Merged

Improve TLS-related rabbitmq.conf settings of amqp_client (backport #15772)#15773
michaelklishin merged 2 commits intov4.3.xfrom
mergify/bp/v4.3.x/pr-15772

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Mar 18, 2026

This is #15767 by @lukebakken with some tweaks from me:

  1. A few places quietly returned undefined instead of using cuttlefish:unset/0
  2. The SNI key used cuttlefish:unset/0 where it should have used disable when the value is set to none in rabbitmq.conf (the current behavior ends up deriving the SNI from the local hostname (a dubious behavior in the Erlang/OTP's ssl or inet apps if you ask me)
  3. Added a bunch of config_schema_SUITE test cases for less commonly used TLS-related keys

References

  1. cuttlefish tls schema for amqp_client #11415
  2. Revert "cuttlefish tls schema for amqp_client" #11531
  3. Re-submit cuttlefish tls schema for amqp_client #15767
    This is an automatic backport of pull request Improve TLS-related rabbitmq.conf settings of amqp_client #15772 done by Mergify.

lukebakken and others added 2 commits March 18, 2026 23:06
@lukebakken @mergify
Revert "Merge pull request #11531 from rabbitmq/revert-11415-amqp_cli…
86f9b18 
…ent_schema"

This reverts commit 4b4c0fe, reversing
changes made to b9bbf69.

(cherry picked from commit bbb6497)
@michaelklishin @mergify
Rework rabbitmq.conf schema for AMQP 1.0, 0-9-1 clients
22df658 
A follow-up to #15767.

(cherry picked from commit 5c0d7f5)
@michaelklishin michaelklishin added this to the 4.3.0 milestone Mar 18, 2026
@michaelklishin michaelklishin merged commit be9e0ee into v4.3.x Mar 18, 2026
176 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v4.3.x/pr-15772 branch March 18, 2026 23:28
@mergify mergify Bot mentioned this pull request Mar 18, 2026
Merged
michaelklishin added a commit that referenced this pull request Mar 19, 2026
@michaelklishin
Merge pull request #15774 from rabbitmq/mergify/bp/v4.2.x/pr-15773
62edf4f 
Improve TLS-related `rabbitmq.conf` settings of `amqp_client` (backport #15772) (backport #15773)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@michaelklishin michaelklishin

Labels

backport-v4.2.x

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelklishin @lukebakken
⚡