Add service to component (odo add binding)

[datho7561]

Right click on a component in the components view and select "Bind Service" in order to bind the component to an Operator-backed service.

In order for this to work:

• the service binding operator must be installed on the cluster
• an operator that manages instances of services must be installed (I tested with the RHOAS operator)
• there must be an instance of the service that is managed by the operator in the current project

Other things in this PR:

• Add a walkthrough GIF of using the UI
• Add a smoke test to check that the "Bind Service" context menu item exists
• Fix the smoke tests. This includes fixing the existing test case for Test case covering creating a component from component's view #2780, even though we are going to rewrite that as a WebView UI soon. I did this, since for the "Bind Service" smoke test, we need a component present in the components view.

Closes #2668

Signed-off-by: David Thompson davthomp@redhat.com

[codecov]

Codecov Report

Patch coverage: 29.41% and project coverage change: -0.17 ⚠️

Comparison is base (7ad8679) 33.88% compared to head (79b038f) 33.72%.

❗ Current head 79b038f differs from pull request most recent head 694cf06. Consider uploading reports for the commit 694cf06 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2803      +/-   ##
==========================================
- Coverage   33.88%   33.72%   -0.17%     
==========================================
  Files          70       71       +1     
  Lines        4326     4395      +69     
  Branches      777      780       +3     
==========================================
+ Hits         1466     1482      +16     
- Misses       2860     2913      +53     

Impacted Files	Coverage Δ
src/odo/command.ts	13.77% <0.00%> (-0.34%)	⬇️
src/odo3.ts	30.76% <13.33%> (-15.39%)	⬇️
...add-service-binding/addServiceBindingViewLoader.ts	17.24% <17.24%> (ø)
src/openshift/component.ts	15.42% <36.66%> (+0.11%)	⬆️
src/webview/devfile-registry/registryViewLoader.ts	31.11% <100.00%> (+2.22%)	⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[datho7561]

@mohitsuman @msivasubramaniaan this PR is ready for review

[datho7561]

Need to add integration tests for odo add binding Okay I added them

[msivasubramaniaan]

Here are the comments which needs to be addressed in order to UI

• The webview should align with VSCode theme in terms of button color, font size, font family
  
• Binding name accepts the invalid names as well
  
• In order to showing the error message while loading, we can make the button disabled and show the error message based on user input
• Don't open multiple service binding webview for same component

[JessicaJHee]

Works well from my testing! Could consider adding a notification when the service was successfully binded (either in the webview and not have it close on it own, or a vscode window popup?), I wasn't sure if everything worked when the webview closed.

Another small thing with the add service binding button, could we keep that disabled but visible when the user hasn't picked the service or service name instead of replacing the error box? But it's not a big deal so if it takes a long time to implement then I don't think it's worth changing.

[msivasubramaniaan]

There was an error in dev console log while loading the Bind service webview

[rgrunber]

Works for me. We should merge and improve afterwards if there are any other issues.

[mohitsuman]

@datho7561 have we added segment event to this command workflow. We need to update around:

• User opens the webview
• Submits the form

[datho7561]

I added two new events to track the usage of the "Bind Service" UI: startAddBindingWizard and finishAddBindingWizard. We also have the telemetry of when the command fails or is run successfully.

[datho7561]

@msivasubramaniaan if you think it's good, could you please +1 when you have time (no rush)

[datho7561]

@rgrunber let me know if you think it's good. However, I think we are blocked on Muthu giving a +1 in order to merge the PR