Merge dev to main for release 1.7.0#84
Merged
Merged
Conversation
sap_system_facts: Add SID and permission check to facts module
- Consolidate SOAP connection logic into module_utils/sapcontrol_soap.py - Update sap_control_exec.py and sap_hostctrl_exec.py to use shared utilities - Refactor and patch unit tests for correct mocking of shared Client Signed-off-by: Melvin Malagowski <mmalagowski@oxya.com>
sap_hdbsql: Add error handling and secure flags for hdbsql
Signed-off-by: Yannick Douvry <ydouvry@oxya.com>
Signed-off-by: Yannick Douvry <ydouvry@oxya.com>
sapcar_extract: Add overwrite mode and improve exist validation
…sapstartsrv_client.py Signed-off-by: Melvin Malagowski<mmalagowski@oxya.com>
Signed-off-by: Melvin Malagowski <mmalagowski@oxya.com>
sap_control_exec, sap_hostctrl_exec: Refactor to use shared utilities
sap_hdbsql: Add new parameter named properties
sap_control_exec, sap_hostctrl_exec: QoL and Error handling
collection: Update all license headers
collection: Prepare for release 1.7.0
sean-freeman
approved these changes
Mar 13, 2026
sean-freeman
left a comment
sean-freeman
left a comment
Member
There was a problem hiding this comment.
LGTM 👍 based upon previous PR reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.