This repository was archived by the owner on Nov 12, 2025. It is now read-only.
Conversation
…with-get Don't send Content-Type header with GET requests
…pdate Attempt to fix issues with new Gatsby version causing docs not to build
… getting due to a bug
… as it's not near ready to ship and is causing confusion
…riously-starscream Update Starscream, for real this time
The current paths to Star Wars example are broken, so I did update that links
Update Star Wars Example Paths
…le-interceptor Remove Codable Parsing interceptor and interceptor provider (for now)
… canceled in the `didReceive data` method
…ancelling-requests Check task state in `URLSessionClient` before trying to add data
…pollographql#1889) * publish response from the WebsocketTransport to the Apollo store * fix build by making methods public * update tests * update StarWars tests * update Playground * make the `store` optional to init `WebSocketTransport`
…pollographql#1892) * Add docs and improve merging of records from WebSockets into cache. * Fix compiler bug issue
* Update CHANGELOG.md * Update Project-Version.xcconfig * Updated documentation * Fix Subscriptions playground for WebSocketTransport changes
…graphql#1899) Co-authored-by: Renovate Bot <bot@renovateapp.com>
…ographql#1901) * Add ApolloClient execution tests for callback queue * Clean up headerdoc to remove Promise reference
* Remove ApolloMacPlayground * Remove ApolloCodegenFrontendPlayground * Delete Apollo Playground.xcscheme * Update RELEASE_CHECKLIST.md * Update README.md linking to the playground repo * Update docs with link to new playground repo
…llographql#1907) Co-authored-by: Renovate Bot <bot@renovateapp.com>
…lographql#1906) * WIP: Moving Starscream Websocket into ApolloWebSocket * Modernize unsafe data access in compression * Minor cleanup of headers * Clean up use of constants * Break Stream into new file * Cleanup more unsafe code warnings * Cleanup * Fix scoping of WSError * Remove Starscream dependency * Fix websocket protocol configuration * Clean up integration tests * Doc changes from code review requests * Move Starscream files into subfolder * Rename ApolloWebSocket default implementation subfolder
* Update CHANGELOG.md * Update Project-Version.xcconfig * Update documentation
* connect: (21 commits) Allow callbackQueue for Watcher to be specified Extend 'WebSocketTransportDelegate' protocol Expose 'reconnectionInterval' property Extend 'WebSocketTransportDelegate' protocol Made connectingPayload public Exposed a method to connect/disconnect Revert "Made the websocket public" Extend 'WebSocketTransportDelegate' protocol Expose 'reconnectionInterval' property Extend 'WebSocketTransportDelegate' protocol Made connectingPayload public Made the websocket public Expose 'security' for SSL pinning Exposed a method to connect/disconnect Extend 'WebSocketTransportDelegate' protocol Expose 'reconnectionInterval' property Extend 'WebSocketTransportDelegate' protocol Made connectingPayload public Made the websocket public Expose 'security' for SSL pinning ... # Conflicts: # Sources/Apollo/GraphQLQueryWatcher.swift # Sources/ApolloWebSocket/WebSocketTransport.swift
tahirmt
approved these changes
Aug 20, 2021
|
Thanks for working on this |
alalani
approved these changes
Aug 20, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will update our
connectbranch to the latest Apollo version.I created this branch from
connectthen rebased on the0.47.1tag. Afterwards I had to mergeconnectback into this branchHighlights
WebSocketTransportto theApolloStoreapollographql/apollo-ios#1889