Fix up typing on chat components by emlynmac · Pull Request #3988 · Azure/communication-ui-library

emlynmac · 2024-01-09T17:17:45Z

What

noImplicitAny should be re-enabled. This fixes up the chat side of the react-components package.

Why

How Tested

Process & policy checklist

I have updated the project documentation to reflect my changes if necessary.
I have read the CONTRIBUTING documentation.

Is this a breaking change?

This change causes current functionality to break.

github-actions · 2024-01-09T17:21:56Z

Storybook URL https://60c7ae6891f0e90039d7cd54-yftxvrcrdf.chromatic.com/

github-actions · 2024-01-09T17:22:57Z

Calling bundle size is not changed.

Current size: 5621579
Base size: 5621579
Diff size: 0

github-actions · 2024-01-09T17:22:58Z

CallWithChat bundle size is decreased✅.

Current size: 6436527
Base size: 6438453
Diff size: -1926

github-actions · 2024-01-09T17:23:01Z

Chat bundle size is decreased✅.

Current size: 1532384
Base size: 1534310
Diff size: -1926

github-actions · 2024-01-09T17:26:09Z

@azure/communication-react jest test coverage for stable.

	Lines	Statements	Functions	Branches
Base	21966 / 34634 63.42%	21966 / 34634 63.42%	595 / 1039 57.26%	1735 / 2738 63.36%
Current	21978 / 34647 63.43%	21978 / 34647 63.43%	595 / 1039 57.26%	1728 / 2734 63.2%
Diff	12 / 13 0.01%	12 / 13 0.01%	0 / 0 0%	-7 / -4 -0.16%

github-actions · 2024-01-09T17:26:12Z

@azure/communication-react jest test coverage for beta.

	Lines	Statements	Functions	Branches
Base	44167 / 71059 62.15%	44167 / 71059 62.15%	914 / 1995 45.81%	2607 / 4221 61.76%
Current	44177 / 71074 62.15%	44177 / 71074 62.15%	914 / 1995 45.81%	2607 / 4221 61.76%
Diff	10 / 15 0%	10 / 15 0%	0 / 0 0%	0 / 0 0%

github-actions · 2024-01-09T17:36:52Z

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

JoshuaLai · 2024-01-09T21:51:04Z

-  return foregroundColorKeys.reduce((acc, key) => {
-    acc[key] = baseTheme.palette?.[key];
+  return foregroundColorKeys.reduce((acc: Record<string, string>, key) => {
+    const k = key as keyof IPalette;


nitpick: Not the biggest deal, I feel like k can have more context like colorCode or something along those lines. Since that seems to be what keys in IPalette are.

github-actions · 2024-01-09T21:58:55Z

Storybook URL https://60c7ae6891f0e90039d7cd54-pzubxvzfxs.chromatic.com/

github-actions · 2024-01-09T22:54:43Z

Storybook URL https://60c7ae6891f0e90039d7cd54-ycsybxdqqu.chromatic.com/

* [Calling sounds] Stabilize Calling sounds feature (#3969) * stabilize sounds * Change files * Duplicate change files for beta release * build beta API * fix breaking change * build API files * update stable API --------- Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * Fix `noInvalidAny` chat composites (#3987) * [DTMF Dialler] Enable DTMF mode and dialing out mode in dialpad (#3970) * remove code forcing end of number to be edit with key * Change files * Duplicate change files for beta release * add editing mode for dialing and dtmf default * disable input on click if there is no editing * remove ref * build API * fix test for new API * [InlineImage][Test] Resolve resource not found error for inline image placeholder UITest (#3979) * Resolve resource not found error for inline image placeholder UITest * Update UI Testing doc Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> * Resolve issue with inline image placeholder test * Change files * Duplicate change files for beta release --------- Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> * Fix up typing on chat components (#3988) * Replace html-to-react with html-react-parser (#3995) * Enable noImplicitAny in chat-stateful-client (#3998) * Enable noImplicitAny in the chat sample (#4000) * Update component examples for noImplicitAny (#4001) * Make Calling Sample textfield validate the Teams user id format (#3967) * Prevent dialpad unecessarily triggering onChange event (#3963) * [DTMF Dialer] Update Dialpad styles per designs (#3999) * Update Dialpad styles per designs * Change files * Duplicate change files for beta release * fix alignment * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * sizing * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Calling] Send reaction button component (#3997) * Add Spotlight feature to stateful call client (#3993) * Add Spotlight feature to stateful call client * Change files * Duplicate change files for beta release * update api * mark spot light feature as in progress * added code docs * Add spotlight feature selectors and handlers (#4004) * Add Spotlight feature to stateful call client * Change files * Duplicate change files for beta release * update api * mark spot light feature as in progress * update api * Add Spotlight selectors and handlers * Change files * Duplicate change files for beta release * remove ununsed import * remove duplicate handlers already in common calling handlers * memoize spotlightedParticipantIds * remove 'on' prefix from spotlight adapter functions * fix conditional compilation * added code docs * small edit * Change hidesurvey to disablesurvey based on ARB (#4006) * hide survey * Change files * Duplicate change files for beta release --------- Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * [Calling Deps] Update to new Calling beta (#4008) * update to new Calling beta * Change files * Duplicate change files for beta release * cc new type * fix hermetic * fix test mock * Update packages/react-composites ChatComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Add callback when survey is dismissed for selfhost (#4009) * add callback for survey dismissed to selfhost * Change files * Duplicate change files for beta release * build files * [Calling] Send reaction component calling-component-binding and composite changes (#4003) * Add license field for package.json files (#4018) * [Chat] Remove inline image from stable (#4010) * Revert "[Chat] Remove file card group message from stable API (#3940)" This reverts commit 74a97ba. * Revert "[Chat] Rename ImageGallery related Chat Theme (#3936)" This reverts commit 98b9f7d. * Revert Inline Image GA changes * Fix lint issues * Change files * Duplicate change files for beta release * Separate file sharing with inline image * Remove test CC * Update FileDownloadCards.test.tsx * Update ChatScreen.tsx * Merge strings back into main (#4025) * TDBuild - updating localized resource files. * Improve CI workflow (#4016) * Lock Files * Change files * Duplicate change files for beta release * Update lock files * Skip compare jest coverage and compare bundle size CI steps for PRs to release (#4026) * Skip jest test coverage and compare bundle stats steps when base branch is a release branch * Change files * Duplicate change files for beta release * [OCE] Remove beta banner for features that are stable (#4031) * remove sounds beta banner * Change files * Duplicate change files for beta release * [Calling] Applying capability for Reaction feature (#4013) * Fix calling sample joining room with room id query arg (#4032) * Fix calling sample to be able to join room with roomId query arg * Change files * Duplicate change files for beta release * Update packages/react-composites ChatComposite browser test snapshots * Update packages/react-composites ChatComposite browser test snapshots --------- Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: Emlyn Bolton <3941071+emlynmac@users.noreply.github.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mohtasim <99507832+Mohtasim@users.noreply.github.com> Co-authored-by: mgamis-msft <79475487+mgamis-msft@users.noreply.github.com> Co-authored-by: carocao-msft <96077406+carocao-msft@users.noreply.github.com> Co-authored-by: vhuseinova-msft <98852890+vhuseinova-msft@users.noreply.github.com> Co-authored-by: Leah Xia <107075081+Leah-Xia-Microsoft@users.noreply.github.com> Co-authored-by: edwardlee-msft <edwardlee@microsoft.com>

emlynmac added 4 commits January 8, 2024 16:17

update html-to-react

042dd8f

Fix up chat components noImplcitAny

6fb9c3d

Change files

a078138

Duplicate change files for beta release

afb10a1

emlynmac requested review from a team as code owners January 9, 2024 17:17

emlynmac requested review from AmyL219, JamesBurnside, JoshuaLai, Leah-Xia-Microsoft, PorterNan, alkwa-msft, carocao-msft, dmceachernmsft, edwardlee-msft, jimchou-dev, jpeng-ms, mgamis-msft, palatter, prabhjot-msft, vhuseinova-msft and waynemo January 9, 2024 17:17

Merge branch 'main' into emlyn/noimplicitany-chat-components

998ce2d

emlynmac assigned JamesBurnside, JoshuaLai and vhuseinova-msft Jan 9, 2024

vhuseinova-msft reviewed Jan 9, 2024

View reviewed changes

Comment thread packages/react-components/src/components/styles/v8StyleShim.ts

vhuseinova-msft reviewed Jan 9, 2024

View reviewed changes

Comment thread change-beta/@azure-communication-react-83fe8c56-c493-4f0f-8165-c0c50b78b872.json

vhuseinova-msft reviewed Jan 9, 2024

View reviewed changes

Comment thread packages/react-components/src/components/styles/v8StyleShim.ts

JoshuaLai reviewed Jan 9, 2024

View reviewed changes

Comment thread packages/react-components/src/components/ChatMessage/ChatMessageContent.tsx

JoshuaLai reviewed Jan 9, 2024

View reviewed changes

Merge branch 'main' into emlyn/noimplicitany-chat-components

e1c8023

JoshuaLai approved these changes Jan 9, 2024

View reviewed changes

Merge branch 'main' into emlyn/noimplicitany-chat-components

da921bb

vhuseinova-msft approved these changes Jan 9, 2024

View reviewed changes

emlynmac merged commit 508b4f4 into main Jan 9, 2024

emlynmac deleted the emlyn/noimplicitany-chat-components branch January 9, 2024 23:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix up typing on chat components#3988

Fix up typing on chat components#3988
emlynmac merged 7 commits intomainfrom
emlyn/noimplicitany-chat-components

emlynmac commented Jan 9, 2024

Uh oh!

github-actions Bot commented Jan 9, 2024

Uh oh!

github-actions Bot commented Jan 9, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 9, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 9, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 9, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 9, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 9, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshuaLai Jan 9, 2024

Uh oh!

github-actions Bot commented Jan 9, 2024

Uh oh!

github-actions Bot commented Jan 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

emlynmac commented Jan 9, 2024

What

Why

How Tested

Process & policy checklist

Uh oh!

github-actions Bot commented Jan 9, 2024

Uh oh!

github-actions Bot commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Calling bundle size is not changed.

Uh oh!

github-actions Bot commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CallWithChat bundle size is decreased✅.

Uh oh!

github-actions Bot commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chat bundle size is decreased✅.

Uh oh!

github-actions Bot commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@azure/communication-react jest test coverage for stable.

Uh oh!

github-actions Bot commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@azure/communication-react jest test coverage for beta.

Uh oh!

github-actions Bot commented Jan 9, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshuaLai Jan 9, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 9, 2024

Uh oh!

github-actions Bot commented Jan 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Jan 9, 2024 •

edited

Loading

github-actions Bot commented Jan 9, 2024 •

edited

Loading

github-actions Bot commented Jan 9, 2024 •

edited

Loading

github-actions Bot commented Jan 9, 2024 •

edited

Loading

github-actions Bot commented Jan 9, 2024 •

edited

Loading