[Calling] Send reaction component calling-component-binding and composite changes by Mohtasim · Pull Request #4003 · Azure/communication-ui-library

Mohtasim · 2024-01-11T01:25:21Z

What

The change contains the following package updates:

calling-component-bindings
react-composites
communication-react

Why

How Tested

Process & policy checklist

I have updated the project documentation to reflect my changes if necessary.
I have read the CONTRIBUTING documentation.

Is this a breaking change?

This change causes current functionality to break.

Signed-off-by: Mohtasim <mbellah@microsoft.com>

…napshots

…/communication-ui-library into mbellah/send_component_woc

github-actions · 2024-01-13T01:38:58Z

Storybook URL https://60c7ae6891f0e90039d7cd54-kmioibleit.chromatic.com/

github-actions · 2024-01-13T01:57:54Z

Storybook URL https://60c7ae6891f0e90039d7cd54-brvtkzjdot.chromatic.com/

github-actions · 2024-01-13T02:08:43Z

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

JamesBurnside · 2024-01-15T17:04:00Z

Legacy control bar should not have the down chevron here:

Removing the chevron altogether now according to figma.

Signed-off-by: Mohtasim <mbellah@microsoft.com>

github-actions · 2024-01-15T17:28:52Z

Storybook URL https://60c7ae6891f0e90039d7cd54-eegdfctgsj.chromatic.com/

github-actions · 2024-01-15T17:34:51Z

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

github-actions · 2024-01-15T17:38:00Z

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Signed-off-by: Mohtasim <mbellah@microsoft.com>

github-actions · 2024-01-15T17:50:37Z

Storybook URL https://60c7ae6891f0e90039d7cd54-vksnajkrom.chromatic.com/

github-actions · 2024-01-15T18:01:42Z

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

github-actions · 2024-01-15T18:02:56Z

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

…napshots

github-actions · 2024-01-15T18:22:24Z

Storybook URL https://60c7ae6891f0e90039d7cd54-kxtcabeevl.chromatic.com/

…/communication-ui-library into mbellah/send_component_woc

github-actions · 2024-01-15T18:31:23Z

Storybook URL https://60c7ae6891f0e90039d7cd54-fmcjndprtc.chromatic.com/

* [Calling sounds] Stabilize Calling sounds feature (#3969) * stabilize sounds * Change files * Duplicate change files for beta release * build beta API * fix breaking change * build API files * update stable API --------- Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * Fix `noInvalidAny` chat composites (#3987) * [DTMF Dialler] Enable DTMF mode and dialing out mode in dialpad (#3970) * remove code forcing end of number to be edit with key * Change files * Duplicate change files for beta release * add editing mode for dialing and dtmf default * disable input on click if there is no editing * remove ref * build API * fix test for new API * [InlineImage][Test] Resolve resource not found error for inline image placeholder UITest (#3979) * Resolve resource not found error for inline image placeholder UITest * Update UI Testing doc Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> * Resolve issue with inline image placeholder test * Change files * Duplicate change files for beta release --------- Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> * Fix up typing on chat components (#3988) * Replace html-to-react with html-react-parser (#3995) * Enable noImplicitAny in chat-stateful-client (#3998) * Enable noImplicitAny in the chat sample (#4000) * Update component examples for noImplicitAny (#4001) * Make Calling Sample textfield validate the Teams user id format (#3967) * Prevent dialpad unecessarily triggering onChange event (#3963) * [DTMF Dialer] Update Dialpad styles per designs (#3999) * Update Dialpad styles per designs * Change files * Duplicate change files for beta release * fix alignment * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * sizing * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Calling] Send reaction button component (#3997) * Add Spotlight feature to stateful call client (#3993) * Add Spotlight feature to stateful call client * Change files * Duplicate change files for beta release * update api * mark spot light feature as in progress * added code docs * Add spotlight feature selectors and handlers (#4004) * Add Spotlight feature to stateful call client * Change files * Duplicate change files for beta release * update api * mark spot light feature as in progress * update api * Add Spotlight selectors and handlers * Change files * Duplicate change files for beta release * remove ununsed import * remove duplicate handlers already in common calling handlers * memoize spotlightedParticipantIds * remove 'on' prefix from spotlight adapter functions * fix conditional compilation * added code docs * small edit * Change hidesurvey to disablesurvey based on ARB (#4006) * hide survey * Change files * Duplicate change files for beta release --------- Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * [Calling Deps] Update to new Calling beta (#4008) * update to new Calling beta * Change files * Duplicate change files for beta release * cc new type * fix hermetic * fix test mock * Update packages/react-composites ChatComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Add callback when survey is dismissed for selfhost (#4009) * add callback for survey dismissed to selfhost * Change files * Duplicate change files for beta release * build files * [Calling] Send reaction component calling-component-binding and composite changes (#4003) * Add license field for package.json files (#4018) * [Chat] Remove inline image from stable (#4010) * Revert "[Chat] Remove file card group message from stable API (#3940)" This reverts commit 74a97ba. * Revert "[Chat] Rename ImageGallery related Chat Theme (#3936)" This reverts commit 98b9f7d. * Revert Inline Image GA changes * Fix lint issues * Change files * Duplicate change files for beta release * Separate file sharing with inline image * Remove test CC * Update FileDownloadCards.test.tsx * Update ChatScreen.tsx * Merge strings back into main (#4025) * TDBuild - updating localized resource files. * Improve CI workflow (#4016) * Lock Files * Change files * Duplicate change files for beta release * Update lock files * Skip compare jest coverage and compare bundle size CI steps for PRs to release (#4026) * Skip jest test coverage and compare bundle stats steps when base branch is a release branch * Change files * Duplicate change files for beta release * [OCE] Remove beta banner for features that are stable (#4031) * remove sounds beta banner * Change files * Duplicate change files for beta release * [Calling] Applying capability for Reaction feature (#4013) * Fix calling sample joining room with room id query arg (#4032) * Fix calling sample to be able to join room with roomId query arg * Change files * Duplicate change files for beta release * Update packages/react-composites ChatComposite browser test snapshots * Update packages/react-composites ChatComposite browser test snapshots --------- Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: Emlyn Bolton <3941071+emlynmac@users.noreply.github.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mohtasim <99507832+Mohtasim@users.noreply.github.com> Co-authored-by: mgamis-msft <79475487+mgamis-msft@users.noreply.github.com> Co-authored-by: carocao-msft <96077406+carocao-msft@users.noreply.github.com> Co-authored-by: vhuseinova-msft <98852890+vhuseinova-msft@users.noreply.github.com> Co-authored-by: Leah Xia <107075081+Leah-Xia-Microsoft@users.noreply.github.com> Co-authored-by: edwardlee-msft <edwardlee@microsoft.com>

Mohtasim and others added 28 commits January 10, 2024 11:16

Send reaction button component

4302d5f

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Merge branch 'main' into mbellah/send_component_react

02218a8

Reaction button PR review feedback addressed

9fe0d40

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Change files

bf88536

Duplicate change files for beta release

131cf5b

Reaction button emoji style js-doc for style

8bdfccf

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Merge branch 'main' into mbellah/send_component_react

74dc19a

Export Reaction Button interfaces

eadd462

Signed-off-by: Mohtasim <mbellah@microsoft.com>

react-component eslint warning fix for CI job

f73e891

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Reaction Rendering example on VideoTile Storybook

05b2b65

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Storyboard - reaction animation rendering

8f6ab62

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Temp working commit

4abfcce

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Test Commit - build success

27310d1

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Reaction Received fron remote participants

0c03b91

Signed-off-by: Mohtasim <mbellah@microsoft.com>

ccc on calling-component-bindings

b1b4b32

Signed-off-by: Mohtasim <mbellah@microsoft.com>

ccc implying on calling-stateful-client

f011dd2

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Implying ccc on communication-react

b12af2f

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Enforcing ccc on react-components

7d66e90

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Implying ccc for reaction feature

f28a1df

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Reaction Button Initial UI Implementation

670c167

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Reaction temp commit

87c3a95

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Fixing a circular dependency issue

9f63087

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Send reaction to meeting

51c2e0b

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Render Reactions according to figma and dismiss onclick

9975418

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Resolving error for callWithChat for callApater API

227205a

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Reaction send component merge with receive component

b3d23ff

Signed-off-by: Mohtasim <mbellah@microsoft.com>

API signature update

ff70698

Signed-off-by: Mohtasim <mbellah@microsoft.com>

CC fixes for reaction feature

df13741

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Mohtasim changed the base branch from main to mbellah/send_component_react January 11, 2024 01:25

VideoTile component keyframe html injection removal

8fac1ff

Signed-off-by: Mohtasim <mbellah@microsoft.com>

github-actions Bot added 4 commits January 13, 2024 01:33

Update packages/react-composites CallWithChatComposite browser test s…

a93704e

…napshots

Merge branch 'mbellah/send_component_woc' of https://github.com/Azure…

81c980e

…/communication-ui-library into mbellah/send_component_woc

Update packages/react-composites CallComposite browser test snapshots

67cb89c

Merge branch 'mbellah/send_component_woc' of https://github.com/Azure…

138ad57

…/communication-ui-library into mbellah/send_component_woc

Merge branch 'main' into mbellah/send_component_woc

bfd74e1

JamesBurnside reviewed Jan 15, 2024

View reviewed changes

Comment thread packages/react-composites/src/composites/common/ControlBar/CommonCallControlBar.tsx Outdated

JamesBurnside reviewed Jan 15, 2024

View reviewed changes

Correcting button appearance due to merge conflict

953f5a5

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Removing chevron from the fluent button according to figma

be8baa3

Signed-off-by: Mohtasim <mbellah@microsoft.com>

Mohtasim added the update_snapshots Set this label to request automated update of UI snapshots label Jan 15, 2024

github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 15, 2024

Update packages/react-composites CallWithChatComposite browser test s…

a985e3f

…napshots

github-actions Bot added 2 commits January 15, 2024 18:27

Update packages/react-composites CallComposite browser test snapshots

6117d3a

Merge branch 'mbellah/send_component_woc' of https://github.com/Azure…

fe3cbc8

…/communication-ui-library into mbellah/send_component_woc

JamesBurnside approved these changes Jan 15, 2024

View reviewed changes

dmceachernmsft approved these changes Jan 15, 2024

View reviewed changes

Mohtasim merged commit 765ce4f into main Jan 15, 2024

Mohtasim deleted the mbellah/send_component_woc branch January 15, 2024 19:45

Conversation

Mohtasim commented Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

How Tested

Process & policy checklist

Uh oh!

github-actions Bot commented Jan 13, 2024

Uh oh!

github-actions Bot commented Jan 13, 2024

Uh oh!

github-actions Bot commented Jan 13, 2024

Uh oh!

Uh oh!

JamesBurnside Jan 15, 2024

Choose a reason for hiding this comment

Uh oh!

Mohtasim Jan 15, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 15, 2024

Uh oh!

github-actions Bot commented Jan 15, 2024

Uh oh!

github-actions Bot commented Jan 15, 2024

Uh oh!

github-actions Bot commented Jan 15, 2024

Uh oh!

github-actions Bot commented Jan 15, 2024

Uh oh!

github-actions Bot commented Jan 15, 2024

Uh oh!

github-actions Bot commented Jan 15, 2024

Uh oh!

github-actions Bot commented Jan 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Mohtasim commented Jan 11, 2024 •

edited

Loading