Add callback when survey is dismissed for selfhost by carocao-msft · Pull Request #4009 · Azure/communication-ui-library

carocao-msft · 2024-01-12T23:34:50Z

What

Add callback when survey is dismissed for selfhost

Why

On selfhost we skip the end call screen hence the survey is skipped
To show the survey, we want to enable the endcall screen and redirect users to home screen when survey is submitted / dismissed
This PR is to add a call back so we can do something when survey is dismissed

How Tested

Test with samples

Process & policy checklist

I have updated the project documentation to reflect my changes if necessary.
I have read the CONTRIBUTING documentation.

Is this a breaking change?

This change causes current functionality to break.

github-actions · 2024-01-12T23:38:45Z

Storybook URL https://60c7ae6891f0e90039d7cd54-bmmojtlhzi.chromatic.com/

github-actions · 2024-01-12T23:40:12Z

Chat bundle size is decreased✅.

Current size: 1439566
Base size: 1439567
Diff size: -1

github-actions · 2024-01-12T23:40:15Z

Calling bundle size is increased❗.

Current size: 5725734
Base size: 5725616
Diff size: 118

github-actions · 2024-01-12T23:40:18Z

CallWithChat bundle size is increased❗.

Current size: 6447225
Base size: 6447107
Diff size: 118

github-actions · 2024-01-12T23:42:45Z

@azure/communication-react jest test coverage for stable.

	Lines	Statements	Functions	Branches
Base	22034 / 34661 63.57%	22034 / 34661 63.57%	592 / 1039 56.97%	1717 / 2734 62.8%
Current	21985 / 34661 63.42%	21985 / 34661 63.42%	592 / 1039 56.97%	1737 / 2742 63.34%
Diff	-49 / 0 -0.15%	-49 / 0 -0.15%	0 / 0 0%	20 / 8 0.54%

github-actions · 2024-01-12T23:42:47Z

@azure/communication-react jest test coverage for beta.

	Lines	Statements	Functions	Branches
Base	44384 / 71508 62.06%	44384 / 71508 62.06%	911 / 2009 45.34%	2621 / 4234 61.9%
Current	44351 / 71546 61.98%	44351 / 71546 61.98%	911 / 2009 45.34%	2591 / 4211 61.52%
Diff	-33 / 38 -0.08%	-33 / 38 -0.08%	0 / 0 0%	-30 / -23 -0.38%

dmceachernmsft · 2024-01-12T23:37:45Z

     * @defaultValue false
     */
    hideSurvey?: boolean;
+    /* @conditional-compile-remove(end-of-call-survey-self-host) */


why does this need to be CC'd separately?

this is for self host only we don't want to release it

dmceachernmsft · 2024-01-13T00:39:23Z

+    /**
+     * Optional callback to add extra logic when survey is dismissed. For self-host only
+     */
+    onSurveyDismissed?: () => void;


This feels like something that Contoso might want if we are wanting it in our devlopment. would be interested to see what they have to say in the devex if this is included 😊

ARB for this feature is already completed, we can save this for version 2

github-actions · 2024-01-13T01:40:06Z

Storybook URL https://60c7ae6891f0e90039d7cd54-nehiptenci.chromatic.com/

* [Calling sounds] Stabilize Calling sounds feature (#3969) * stabilize sounds * Change files * Duplicate change files for beta release * build beta API * fix breaking change * build API files * update stable API --------- Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * Fix `noInvalidAny` chat composites (#3987) * [DTMF Dialler] Enable DTMF mode and dialing out mode in dialpad (#3970) * remove code forcing end of number to be edit with key * Change files * Duplicate change files for beta release * add editing mode for dialing and dtmf default * disable input on click if there is no editing * remove ref * build API * fix test for new API * [InlineImage][Test] Resolve resource not found error for inline image placeholder UITest (#3979) * Resolve resource not found error for inline image placeholder UITest * Update UI Testing doc Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> * Resolve issue with inline image placeholder test * Change files * Duplicate change files for beta release --------- Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> * Fix up typing on chat components (#3988) * Replace html-to-react with html-react-parser (#3995) * Enable noImplicitAny in chat-stateful-client (#3998) * Enable noImplicitAny in the chat sample (#4000) * Update component examples for noImplicitAny (#4001) * Make Calling Sample textfield validate the Teams user id format (#3967) * Prevent dialpad unecessarily triggering onChange event (#3963) * [DTMF Dialer] Update Dialpad styles per designs (#3999) * Update Dialpad styles per designs * Change files * Duplicate change files for beta release * fix alignment * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * sizing * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Calling] Send reaction button component (#3997) * Add Spotlight feature to stateful call client (#3993) * Add Spotlight feature to stateful call client * Change files * Duplicate change files for beta release * update api * mark spot light feature as in progress * added code docs * Add spotlight feature selectors and handlers (#4004) * Add Spotlight feature to stateful call client * Change files * Duplicate change files for beta release * update api * mark spot light feature as in progress * update api * Add Spotlight selectors and handlers * Change files * Duplicate change files for beta release * remove ununsed import * remove duplicate handlers already in common calling handlers * memoize spotlightedParticipantIds * remove 'on' prefix from spotlight adapter functions * fix conditional compilation * added code docs * small edit * Change hidesurvey to disablesurvey based on ARB (#4006) * hide survey * Change files * Duplicate change files for beta release --------- Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * [Calling Deps] Update to new Calling beta (#4008) * update to new Calling beta * Change files * Duplicate change files for beta release * cc new type * fix hermetic * fix test mock * Update packages/react-composites ChatComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Add callback when survey is dismissed for selfhost (#4009) * add callback for survey dismissed to selfhost * Change files * Duplicate change files for beta release * build files * [Calling] Send reaction component calling-component-binding and composite changes (#4003) * Add license field for package.json files (#4018) * [Chat] Remove inline image from stable (#4010) * Revert "[Chat] Remove file card group message from stable API (#3940)" This reverts commit 74a97ba. * Revert "[Chat] Rename ImageGallery related Chat Theme (#3936)" This reverts commit 98b9f7d. * Revert Inline Image GA changes * Fix lint issues * Change files * Duplicate change files for beta release * Separate file sharing with inline image * Remove test CC * Update FileDownloadCards.test.tsx * Update ChatScreen.tsx * Merge strings back into main (#4025) * TDBuild - updating localized resource files. * Improve CI workflow (#4016) * Lock Files * Change files * Duplicate change files for beta release * Update lock files * Skip compare jest coverage and compare bundle size CI steps for PRs to release (#4026) * Skip jest test coverage and compare bundle stats steps when base branch is a release branch * Change files * Duplicate change files for beta release * [OCE] Remove beta banner for features that are stable (#4031) * remove sounds beta banner * Change files * Duplicate change files for beta release * [Calling] Applying capability for Reaction feature (#4013) * Fix calling sample joining room with room id query arg (#4032) * Fix calling sample to be able to join room with roomId query arg * Change files * Duplicate change files for beta release * Update packages/react-composites ChatComposite browser test snapshots * Update packages/react-composites ChatComposite browser test snapshots --------- Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Signed-off-by: Patrick Latter <73612854+palatter@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: Emlyn Bolton <3941071+emlynmac@users.noreply.github.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mohtasim <99507832+Mohtasim@users.noreply.github.com> Co-authored-by: mgamis-msft <79475487+mgamis-msft@users.noreply.github.com> Co-authored-by: carocao-msft <96077406+carocao-msft@users.noreply.github.com> Co-authored-by: vhuseinova-msft <98852890+vhuseinova-msft@users.noreply.github.com> Co-authored-by: Leah Xia <107075081+Leah-Xia-Microsoft@users.noreply.github.com> Co-authored-by: edwardlee-msft <edwardlee@microsoft.com>

carocao-msft added 3 commits January 12, 2024 23:32

add callback for survey dismissed to selfhost

4c339cb

Change files

d43be69

Duplicate change files for beta release

1eb2ddd

carocao-msft assigned JamesBurnside and dmceachernmsft Jan 12, 2024

carocao-msft requested review from a team as code owners January 12, 2024 23:34

carocao-msft requested review from AmyL219, JamesBurnside, JoshuaLai, Leah-Xia-Microsoft, PorterNan, alkwa-msft, dmceachernmsft, edwardlee-msft, emlynmac, jimchou-dev, jpeng-ms, mgamis-msft, palatter, prabhjot-msft, vhuseinova-msft and waynemo January 12, 2024 23:34

JamesBurnside approved these changes Jan 12, 2024

View reviewed changes

dmceachernmsft approved these changes Jan 13, 2024

View reviewed changes

carocao-msft added 2 commits January 13, 2024 01:21

Merge branch 'main' into carocao/self-host

7a19398

build files

0cdea0c

carocao-msft enabled auto-merge (squash) January 13, 2024 01:38

carocao-msft merged commit da732f8 into main Jan 13, 2024

carocao-msft deleted the carocao/self-host branch January 13, 2024 01:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add callback when survey is dismissed for selfhost #4009

Add callback when survey is dismissed for selfhost #4009
carocao-msft merged 5 commits intomainfrom
carocao/self-host

carocao-msft commented Jan 12, 2024

Uh oh!

github-actions Bot commented Jan 12, 2024

Uh oh!

github-actions Bot commented Jan 12, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 12, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 12, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 12, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 12, 2024 •

edited

Loading

Uh oh!

dmceachernmsft Jan 12, 2024

Uh oh!

carocao-msft Jan 13, 2024

Uh oh!

dmceachernmsft Jan 13, 2024

Uh oh!

carocao-msft Jan 13, 2024

Uh oh!

github-actions Bot commented Jan 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

carocao-msft commented Jan 12, 2024

What

Why

How Tested

Process & policy checklist

Uh oh!

github-actions Bot commented Jan 12, 2024

Uh oh!

github-actions Bot commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chat bundle size is decreased✅.

Uh oh!

github-actions Bot commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Calling bundle size is increased❗.

Uh oh!

github-actions Bot commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CallWithChat bundle size is increased❗.

Uh oh!

github-actions Bot commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@azure/communication-react jest test coverage for stable.

Uh oh!

github-actions Bot commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@azure/communication-react jest test coverage for beta.

Uh oh!

dmceachernmsft Jan 12, 2024

Choose a reason for hiding this comment

Uh oh!

carocao-msft Jan 13, 2024

Choose a reason for hiding this comment

Uh oh!

dmceachernmsft Jan 13, 2024

Choose a reason for hiding this comment

Uh oh!

carocao-msft Jan 13, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jan 12, 2024 •

edited

Loading

github-actions Bot commented Jan 12, 2024 •

edited

Loading

github-actions Bot commented Jan 12, 2024 •

edited

Loading

github-actions Bot commented Jan 12, 2024 •

edited

Loading

github-actions Bot commented Jan 12, 2024 •

edited

Loading